Tarantool development patches archive
 help / color / mirror / Atom feed
From: sergeyb@tarantool.org
To: tarantool-patches@dev.tarantool.org, imun@tarantool.org,
	v.shpilevoy@tarantool.org
Cc: alexander.turenko@tarantool.org
Subject: [Tarantool-patches] [PATCH 3/6] gitlab-ci: enable static analysis with luacheck
Date: Thu,  4 Jun 2020 11:39:07 +0300	[thread overview]
Message-ID: <583d21ee6a9849ea4eaa8e5c133c1bc5fa36c577.1591259297.git.sergeyb@tarantool.org> (raw)
In-Reply-To: <cover.1591259297.git.sergeyb@tarantool.org>

From: Sergey Bronnikov <sergeyb@tarantool.org>

Part of #4681
---
 .gitlab-ci.yml | 11 +++++++++++
 .travis.mk     | 23 ++++++++++++++++++++++-
 2 files changed, 33 insertions(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 7705631dd..041653dae 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -1,4 +1,5 @@
 stages:
+  - static_analysis
   - test
   - perf
   - cleanup
@@ -107,6 +108,16 @@ variables:
    script:
      - ${GITLAB_MAKE} perf_cleanup
 
+# Static Analysis
+
+luacheck:
+  <<: *docker_test_definition
+  stage: static_analysis
+  tags:
+    - deploy_test
+  script:
+    - ${GITLAB_MAKE} test_debian_docker_luacheck
+
 # Tests
 
 release:
diff --git a/.travis.mk b/.travis.mk
index 063537f25..aaceaab34 100644
--- a/.travis.mk
+++ b/.travis.mk
@@ -3,9 +3,11 @@
 #
 
 DOCKER_IMAGE?=packpack/packpack:debian-stretch
+DOCKER_IMAGE_TARANTOOL="registry.gitlab.com/tarantool/tarantool/testing/debian-stretch:latest"
 TEST_RUN_EXTRA_PARAMS?=
 MAX_FILES?=65534
 MAX_PROC?=2500
+OOS_SRC_PATH="/source"
 
 all: package
 
@@ -76,8 +78,10 @@ deps_buster_clang_8: deps_debian
 
 # Release
 
-build_debian:
+configure_debian:
 	cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_WERROR=ON ${CMAKE_EXTRA_PARAMS}
+
+build_debian: configure_debian
 	make -j
 
 test_debian_no_deps: build_debian
@@ -146,6 +150,23 @@ test_static_build: deps_debian_static
 test_static_docker_build:
 	docker build --no-cache --network=host --build-arg RUN_TESTS=ON -f Dockerfile.staticbuild .
 
+# ###################
+# Static Analysis
+# ###################
+
+test_debian_docker_luacheck:
+	docker run -w ${OOS_SRC_PATH} -v ${PWD}:${OOS_SRC_PATH} --privileged \
+		--cap-add=sys_nice --network=host -i ${DOCKER_IMAGE_TARANTOOL} \
+		make -f .travis.mk test_debian_luacheck
+
+test_debian_install_luacheck:
+	apt update -y
+	apt install -y lua5.1 luarocks
+	luarocks install luacheck
+
+test_debian_luacheck: test_debian_install_luacheck configure_debian
+	make luacheck
+
 #######
 # OSX #
 #######
-- 
2.23.0

  parent reply	other threads:[~2020-06-04  8:41 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04  8:39 [Tarantool-patches] [PATCH 0/6] Add static analysis of Lua code in src/ and extra/ " sergeyb
2020-06-04  8:39 ` [Tarantool-patches] [PATCH 1/6] Add initial luacheck config sergeyb
2020-06-06 18:02   ` Vladislav Shpilevoy
2020-06-09 16:16     ` Sergey Bronnikov
2020-06-04  8:39 ` [Tarantool-patches] [PATCH 2/6] build: enable 'make luacheck' target sergeyb
2020-06-04  8:39 ` sergeyb [this message]
2020-06-04  8:39 ` [Tarantool-patches] [PATCH 4/6] Fix luacheck warnings in extra/dist/ sergeyb
2020-06-06 18:02   ` Vladislav Shpilevoy
2020-06-09 16:17     ` Sergey Bronnikov
2020-06-19 23:15   ` Vladislav Shpilevoy
2020-07-05 16:28     ` Vladislav Shpilevoy
2020-07-12 15:37       ` Vladislav Shpilevoy
2020-07-13 10:01     ` Sergey Bronnikov
2020-06-04  8:39 ` [Tarantool-patches] [PATCH 5/6] Fix luacheck warnings in src/lua/ sergeyb
2020-06-06 18:03   ` Vladislav Shpilevoy
2020-06-11 12:00     ` Sergey Bronnikov
2020-06-11 19:52       ` Vladislav Shpilevoy
2020-06-18  9:32         ` Sergey Bronnikov
2020-06-18  9:35       ` Sergey Bronnikov
2020-06-11 17:22     ` Igor Munkin
2020-07-05 16:28   ` Vladislav Shpilevoy
2020-07-10 16:55     ` Sergey Bronnikov
2020-07-12 15:37       ` Vladislav Shpilevoy
2020-07-13  9:51         ` Sergey Bronnikov
2020-07-13 22:59   ` Vladislav Shpilevoy
2020-06-04  8:39 ` [Tarantool-patches] [PATCH 6/6] Fix luacheck warnings in src/box/lua/ sergeyb
2020-06-06 18:03   ` Vladislav Shpilevoy
2020-06-11 12:01     ` Sergey Bronnikov
2020-06-18  9:37       ` Sergey Bronnikov
2020-06-19 23:15   ` Vladislav Shpilevoy
2020-07-01 14:02     ` Sergey Bronnikov
2020-07-13 22:59   ` Vladislav Shpilevoy
2020-07-14 10:54     ` Sergey Bronnikov
2020-07-14 11:24       ` Sergey Bronnikov
2020-06-04  8:43 ` [Tarantool-patches] [PATCH 0/6] Add static analysis of Lua code in src/ and extra/ with luacheck Sergey Bronnikov
2020-06-19 23:15   ` Vladislav Shpilevoy
2020-07-13  9:53     ` Sergey Bronnikov
2020-06-04  9:04 ` Igor Munkin
2020-06-04 11:17 ` Sergey Bronnikov
2020-07-14 22:49 ` Vladislav Shpilevoy
2020-07-15  9:51 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=583d21ee6a9849ea4eaa8e5c133c1bc5fa36c577.1591259297.git.sergeyb@tarantool.org \
    --to=sergeyb@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=imun@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 3/6] gitlab-ci: enable static analysis with luacheck' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox