Tarantool development patches archive
 help / color / mirror / Atom feed
* [tarantool-patches] [PATCH v1 1/1] app: example.lua does not start
@ 2018-08-16 11:35 imeevma
  2018-08-16 20:58 ` [tarantool-patches] " Vladislav Shpilevoy
  0 siblings, 1 reply; 2+ messages in thread
From: imeevma @ 2018-08-16 11:35 UTC (permalink / raw)
  To: tarantool-patches; +Cc: v.shpilevoy

According to #3072 log_nonblock cannot be used in
given case. This patch set this option to "false".

Closes #3348
---
Branch: https://github.com/tarantool/tarantool/tree/imeevma/gh-3348-example-lua-does-not-start
Issue: https://github.com/tarantool/tarantool/issues/3348

 extra/dist/example.lua | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/extra/dist/example.lua b/extra/dist/example.lua
index 0aa51c6..153d831 100644
--- a/extra/dist/example.lua
+++ b/extra/dist/example.lua
@@ -136,7 +136,7 @@ box.cfg {
 
     -- If true, tarantool does not block on the log file descriptor
     -- when it’s not ready for write, and drops the message instead
-    log_nonblock = true;
+    log_nonblock = false;
 
     -- If processing a request takes longer than
     -- the given value (in seconds), warn about it in the log
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [tarantool-patches] Re: [PATCH v1 1/1] app: example.lua does not start
  2018-08-16 11:35 [tarantool-patches] [PATCH v1 1/1] app: example.lua does not start imeevma
@ 2018-08-16 20:58 ` Vladislav Shpilevoy
  0 siblings, 0 replies; 2+ messages in thread
From: Vladislav Shpilevoy @ 2018-08-16 20:58 UTC (permalink / raw)
  To: tarantool-patches, imeevma

Hi! Thanks for the patch! LGTM. I have pushed the patch into 2.0.

On 16/08/2018 14:35, imeevma@tarantool.org wrote:
> According to #3072 log_nonblock cannot be used in
> given case. This patch set this option to "false".
> 
> Closes #3348
> ---
> Branch: https://github.com/tarantool/tarantool/tree/imeevma/gh-3348-example-lua-does-not-start
> Issue: https://github.com/tarantool/tarantool/issues/3348
> 
>   extra/dist/example.lua | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/extra/dist/example.lua b/extra/dist/example.lua
> index 0aa51c6..153d831 100644
> --- a/extra/dist/example.lua
> +++ b/extra/dist/example.lua
> @@ -136,7 +136,7 @@ box.cfg {
>   
>       -- If true, tarantool does not block on the log file descriptor
>       -- when it’s not ready for write, and drops the message instead
> -    log_nonblock = true;
> +    log_nonblock = false;
>   
>       -- If processing a request takes longer than
>       -- the given value (in seconds), warn about it in the log
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-16 20:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-16 11:35 [tarantool-patches] [PATCH v1 1/1] app: example.lua does not start imeevma
2018-08-16 20:58 ` [tarantool-patches] " Vladislav Shpilevoy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox