From: Oleg Babin <olegrok@tarantool.org>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: Oleg Babin <babinoleg@mail.ru>, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3] error: add __concat method to error object
Date: Tue, 14 Jan 2020 18:02:25 +0300 [thread overview]
Message-ID: <5736c5c2-b38e-7642-5942-af466977d3b4@tarantool.org> (raw)
In-Reply-To: <20200114142136.GB547@tarantool.org>
Thanks for your review!
Yes, you are right but I think that gereral cases have been covered for
"box.error" type.
I've created an issue -
https://github.com/tarantool/tarantool/issues/4725 to generalize such
approach and may be add "__concat" for decimals/uuid/...
Also "decimals" is not available in 1.10 if we want to backport this
patch one day
On 14/01/2020 17:21, Sergey Ostanevich wrote:
> Hi!
>
> Thanks for the patch!
>
> I wonder if you're interested in coverage of all Lua types in tests?
> On my side I found that decimals are not so fancy:
---
Oleg Babin
next prev parent reply other threads:[~2020-01-14 15:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 15:48 olegrok
2020-01-14 14:21 ` Sergey Ostanevich
2020-01-14 15:02 ` Oleg Babin [this message]
2020-01-15 11:26 ` Alexander Turenko
2020-01-15 12:35 ` Oleg Babin
2020-01-16 22:02 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5736c5c2-b38e-7642-5942-af466977d3b4@tarantool.org \
--to=olegrok@tarantool.org \
--cc=babinoleg@mail.ru \
--cc=sergos@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3] error: add __concat method to error object' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox