From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>, korablev@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] box: use tuple_field_raw_by_part where possible
Date: Sat, 21 Nov 2020 00:26:55 +0100 [thread overview]
Message-ID: <5689a42c-1207-2259-9dca-c290ccce0849@tarantool.org> (raw)
In-Reply-To: <20201114172823.8217-3-sergepetrenko@tarantool.org>
Thanks for the patch!
On 14.11.2020 18:28, Serge Petrenko wrote:
> tuple_field_raw_by_part allows to use part's offset slot cache to bypass
> tuple field lookup in a JSON tree, which is involved even for plain
> tuples.
I am not sure I understand. How does it work in 1.10 then? It uses
tuple_field_by_part_raw, which in the end simply calls
tuple_field_raw(format, data, field_map, part->fieldno);
Exactly what we had here. Why did anything change?
> Since both tuple_field_raw_by_part and tuple_field_raw are basically
> aliases to tuple_field_raw_by_path, prefer the former to the latter,
> since it takes advantage over key part's offset slot cache.
Besides, I can't find any info why do we need this 'offset slot cache'.
The comment above this member simply narrates the code, and I don't
understand the actual reason it was added. Did you manage to realize it?
Can you explain, please?
next prev parent reply other threads:[~2020-11-20 23:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 17:28 [Tarantool-patches] [PATCH 0/2] reduce performance degradation introduced by JSON path indices Serge Petrenko
2020-11-14 17:28 ` [Tarantool-patches] [PATCH 1/2] box: speed up tuple_field_map_create Serge Petrenko
2020-11-14 18:00 ` Cyrill Gorcunov
2020-11-16 7:34 ` Serge Petrenko
2020-11-20 23:26 ` Vladislav Shpilevoy
2020-11-23 13:50 ` Serge Petrenko
2020-11-24 22:33 ` Vladislav Shpilevoy
2020-12-01 8:48 ` Serge Petrenko
2020-12-01 22:04 ` Vladislav Shpilevoy
2020-12-02 9:53 ` Serge Petrenko
2020-11-14 17:28 ` [Tarantool-patches] [PATCH 2/2] box: use tuple_field_raw_by_part where possible Serge Petrenko
2020-11-20 23:26 ` Vladislav Shpilevoy [this message]
2020-11-23 13:51 ` Serge Petrenko
2020-11-24 22:33 ` Vladislav Shpilevoy
2020-12-01 8:48 ` Serge Petrenko
2020-12-01 22:04 ` Vladislav Shpilevoy
2020-11-16 7:50 ` [Tarantool-patches] [PATCH 0/2] reduce performance degradation introduced by JSON path indices Serge Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5689a42c-1207-2259-9dca-c290ccce0849@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] box: use tuple_field_raw_by_part where possible' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox