From: Serge Petrenko <sergepetrenko@tarantool.org> To: v.shpilevoy@tarantool.org, korablev@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH 0/2] reduce performance degradation introduced by JSON path indices Date: Sat, 14 Nov 2020 20:28:21 +0300 [thread overview] Message-ID: <20201114172823.8217-1-sergepetrenko@tarantool.org> (raw) The patchset fixes two degradations found by measuring snapshot recovery time for a 1.5G snapshot containing 30M tuples in a memtx space with a simple primary key and one secondary key over 4 integer and one string field. The first degradation manifests itself during snapshot recovery phase (the one with "3.5M rows processed" messages) and is connected to `memtx_tuple_new` slowdown due to unoptimised `tuple_field_map_create`. First patch deals with this degradation and manages to restore almost all performance lost since 1.10. (The patched version is only 11% slower than 1.10, while the current master is 39% slower on this phase). The second degradation appears during next snapshot recovery phase, secondary index building. Here the degradation is rooted in slow tuple field access via tuple_field_raw(). The second patch deals with this issue and manages to restore part of the lost performance. (The patched version is 14% slower than 1.10 while the current master is 27% slower). Serge Petrenko (2): box: speed up tuple_field_map_create box: use tuple_field_raw_by_part where possible src/box/tuple_compare.cc | 37 ++++----------- src/box/tuple_extract_key.cc | 10 +--- src/box/tuple_format.c | 91 ++++++++++++++++++++++++++++++++++++ src/box/tuple_hash.cc | 35 ++++---------- 4 files changed, 111 insertions(+), 62 deletions(-) -- 2.24.3 (Apple Git-128)
next reply other threads:[~2020-11-14 17:28 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-14 17:28 Serge Petrenko [this message] 2020-11-14 17:28 ` [Tarantool-patches] [PATCH 1/2] box: speed up tuple_field_map_create Serge Petrenko 2020-11-14 18:00 ` Cyrill Gorcunov 2020-11-16 7:34 ` Serge Petrenko 2020-11-20 23:26 ` Vladislav Shpilevoy 2020-11-23 13:50 ` Serge Petrenko 2020-11-24 22:33 ` Vladislav Shpilevoy 2020-12-01 8:48 ` Serge Petrenko 2020-12-01 22:04 ` Vladislav Shpilevoy 2020-12-02 9:53 ` Serge Petrenko 2020-11-14 17:28 ` [Tarantool-patches] [PATCH 2/2] box: use tuple_field_raw_by_part where possible Serge Petrenko 2020-11-20 23:26 ` Vladislav Shpilevoy 2020-11-23 13:51 ` Serge Petrenko 2020-11-24 22:33 ` Vladislav Shpilevoy 2020-12-01 8:48 ` Serge Petrenko 2020-12-01 22:04 ` Vladislav Shpilevoy 2020-11-16 7:50 ` [Tarantool-patches] [PATCH 0/2] reduce performance degradation introduced by JSON path indices Serge Petrenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201114172823.8217-1-sergepetrenko@tarantool.org \ --to=sergepetrenko@tarantool.org \ --cc=korablev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 0/2] reduce performance degradation introduced by JSON path indices' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox