From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>,
tarantool-patches@dev.tarantool.org, avtikhon@tarantool.org,
alexander.turenko@tarantool.org, o.piskunov@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 4/6] Fix luacheck warnings in extra/dist/tarantoolctl.in
Date: Wed, 15 Apr 2020 01:30:20 +0200 [thread overview]
Message-ID: <562140a0-b397-5666-7f7b-20c5540adaee@tarantool.org> (raw)
In-Reply-To: <df73ea556e3a8c7558abf7dd91150b07daed6eb6.1586849129.git.sergeyb@tarantool.org>
Thanks for the patch!
Consider more fixes below and on the branch in a separate commit.
That allowed to remove some warning mutes from the luacheck
config.
====================
Review fixes: tarantoolctl.in
diff --git a/extra/dist/tarantoolctl.in b/extra/dist/tarantoolctl.in
index d7f098735..b8e8d0632 100755
--- a/extra/dist/tarantoolctl.in
+++ b/extra/dist/tarantoolctl.in
@@ -132,7 +132,8 @@ local function load_default_file(default_file)
log.error("Failed to load defaults file: %s", msg)
end
debug.setfenv(ufunc, env)
- local state, msg = pcall(ufunc)
+ local state
+ state, msg = pcall(ufunc)
if not state then
log.error('Failed to execute defaults file: %s', msg)
end
next prev parent reply other threads:[~2020-04-14 23:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 7:55 [Tarantool-patches] [PATCH v3 0/6] Add static analysis with luacheck Sergey Bronnikov
2020-04-14 7:56 ` [Tarantool-patches] [PATCH 1/6] Fix luacheck warnings in src/lua/ Sergey Bronnikov
2020-04-14 23:29 ` Vladislav Shpilevoy
2020-04-15 20:51 ` Igor Munkin
2020-04-15 21:40 ` Vladislav Shpilevoy
2020-04-17 9:07 ` Sergey Bronnikov
2020-04-17 9:09 ` Sergey Bronnikov
2020-04-15 20:51 ` Igor Munkin
2020-04-15 21:46 ` Vladislav Shpilevoy
2020-04-16 13:52 ` Igor Munkin
2020-04-17 9:26 ` Sergey Bronnikov
2020-04-17 12:13 ` Igor Munkin
2020-04-14 7:57 ` [Tarantool-patches] [PATCH 2/6] Fix luacheck warnings in test/ Sergey Bronnikov
2020-04-14 23:29 ` Vladislav Shpilevoy
2020-04-17 12:05 ` Igor Munkin
2020-04-17 19:51 ` Sergey Bronnikov
2020-04-17 19:47 ` Sergey Bronnikov
2020-04-16 13:43 ` Igor Munkin
2020-04-14 7:57 ` [Tarantool-patches] [PATCH 3/6] Fix luacheck warnings in src/box/lua/ Sergey Bronnikov
2020-04-14 23:30 ` Vladislav Shpilevoy
2020-04-14 7:58 ` [Tarantool-patches] [PATCH 4/6] Fix luacheck warnings in extra/dist/tarantoolctl.in Sergey Bronnikov
2020-04-14 23:30 ` Vladislav Shpilevoy [this message]
2020-04-15 15:35 ` Igor Munkin
2020-04-14 8:01 ` [Tarantool-patches] [PATCH 5/6] Add luacheck config Sergey Bronnikov
2020-04-14 23:30 ` Vladislav Shpilevoy
2020-04-14 8:01 ` [Tarantool-patches] [PATCH 6/6] gitlab-ci: enable static analysis with luacheck Sergey Bronnikov
2020-04-14 23:30 ` [Tarantool-patches] [PATCH v3 7/6] schema: fix index promotion to functional index Vladislav Shpilevoy
2020-04-14 23:30 ` [Tarantool-patches] [PATCH v3 8/6] schema: fix internal symbols dangling in _G Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562140a0-b397-5666-7f7b-20c5540adaee@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 4/6] Fix luacheck warnings in extra/dist/tarantoolctl.in' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox