Re: [Tarantool-patches] [PATCH v7 9/8] txn: txn_add_redo -- drop synchro processing

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Thanks for the patch!

On 15.08.2020 10:38, Cyrill Gorcunov wrote:
> Since we no longer use txn engine for synchro
> packets processing this code is never executed.
> 
> Part-of #5129
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> Happen to miss this yesterday. I pushed into the same branch.
> 
>  src/box/txn.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/src/box/txn.c b/src/box/txn.c
> index cc1f496c5..b2d342355 100644
> --- a/src/box/txn.c
> +++ b/src/box/txn.c
> @@ -82,14 +82,7 @@ txn_add_redo(struct txn *txn, struct txn_stmt *stmt, struct request *request)
>  	 */
>  	struct space *space = stmt->space;
>  	row->group_id = space != NULL ? space_group_id(space) : 0;
> -	/*
> -	 * Sychronous replication entries are supplementary and
> -	 * aren't valid dml requests. They're encoded manually.
> -	 */
> -	if (likely(!iproto_type_is_synchro_request(row->type)))
> -		row->bodycnt = xrow_encode_dml(request, &txn->region, row->body);
> -	else
> -		row->bodycnt = xrow_header_dup_body(row, &txn->region);

xrow_header_dup_body() can be deleted now.

> +	row->bodycnt = xrow_encode_dml(request, &txn->region, row->body);
>  	if (row->bodycnt < 0)
>  		return -1;
>  	stmt->row = row;
>