Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Oleg Babin <olegrok@tarantool.org>, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] tuple: make box.tuple.is() public
Date: Mon, 17 Feb 2020 22:11:00 +0100	[thread overview]
Message-ID: <55f02685-1ebe-6292-eda6-0f999f8ce42a@tarantool.org> (raw)
In-Reply-To: <88d81178-4ada-c346-5c2c-7f2132d181d9@tarantool.org>

Hi!

Ok, changed back to box.tuple.is() doc request.
New commit message:

	tuple: document all missed box.tuple.* methods

	In #4684 it was found that box.tuple.* contained some private
	functions: bless(), encode(), and is().

	Bless() and encode() didn't make any sense for a user, so they
	were hidden into box.internal.tuple.*.

	But box.tuple.is() is actually a useful thing. It is harnessed in
	the tests a lot, and is likely to be already used by customers,
	because it is available in box.tuple.* for a long time. It is a
	matter of time when someone will open a doc ticket saying that
	box.tuple.is() is not documented. The patch makes it legally
	public.

	Follow-up #4684

	@TarantoolBot document
	Title: box.tuple.is()
	```Lua
	box.tuple.is(object)
	```
	A function to check whether a given object is a tuple cdata
	object. Returns true or false. Never raises nor returns an error.

  reply	other threads:[~2020-02-17 21:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-15 18:08 [Tarantool-patches] [PATCH 0/2] box.tuple.* cleanup Vladislav Shpilevoy
2020-02-15 18:08 ` [Tarantool-patches] [PATCH 1/2] tuple: hide internal functions from box.tuple.* Vladislav Shpilevoy
2020-03-16 13:15   ` Nikita Pettik
2020-02-15 18:08 ` [Tarantool-patches] [PATCH 2/2] tuple: make box.tuple.is() public Vladislav Shpilevoy
2020-02-16 15:07   ` Vladislav Shpilevoy
2020-02-17 20:21     ` Oleg Babin
2020-02-17 21:11       ` Vladislav Shpilevoy [this message]
2020-03-16 13:19   ` Nikita Pettik
2020-02-15 19:02 ` [Tarantool-patches] [PATCH 0/2] box.tuple.* cleanup Oleg Babin
2020-02-16 15:07 ` Vladislav Shpilevoy
2020-03-01 14:21 ` Igor Munkin
2020-03-15 17:42 ` Vladislav Shpilevoy
2020-03-15 22:38   ` Nikita Pettik
2020-03-16 14:07 ` Kirill Yukhin
2020-03-16 17:48   ` Nikita Pettik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55f02685-1ebe-6292-eda6-0f999f8ce42a@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=olegrok@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 2/2] tuple: make box.tuple.is() public' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox