From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/3] box: fix struct port_tuple.size wrong type in Lua
Date: Wed, 11 Mar 2020 01:17:33 +0100 [thread overview]
Message-ID: <55b7ae51-ddd9-cdce-ddc5-3c0e30942842@tarantool.org> (raw)
In-Reply-To: <20200310134250.GB26141@tarantool.org>
On 10/03/2020 14:42, Nikita Pettik wrote:
> On 08 Mar 18:47, Vladislav Shpilevoy wrote:
>> Original port_tuple in C has 'int size;' field. It was
>> 'size_t size' in Lua. Since sizeof(size_t) usually is
>> 8, and sizeof(int) is 4, this was a really bad typo.
>
> LGTM (feel free to push out of order as obvious).
Done. Pushed to master, 2.3, 2.2, 1.10.
next prev parent reply other threads:[~2020-03-11 0:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 17:47 [Tarantool-patches] [PATCH 0/3] box_return_mp Vladislav Shpilevoy
2020-03-08 17:47 ` [Tarantool-patches] [PATCH 1/3] box: fix struct port_tuple.size wrong type in Lua Vladislav Shpilevoy
2020-03-10 13:42 ` Nikita Pettik
2020-03-11 0:17 ` Vladislav Shpilevoy [this message]
2020-03-08 17:47 ` [Tarantool-patches] [PATCH 2/3] box: introduce port_c Vladislav Shpilevoy
2020-03-26 17:49 ` Nikita Pettik
2020-04-23 0:14 ` Vladislav Shpilevoy
2020-04-27 14:09 ` Nikita Pettik
2020-04-27 21:28 ` Vladislav Shpilevoy
2020-04-27 23:24 ` Nikita Pettik
2020-04-03 14:12 ` Igor Munkin
2020-04-23 0:14 ` Vladislav Shpilevoy
2020-03-08 17:47 ` [Tarantool-patches] [PATCH 3/3] box: introduce box_return_mp() public C function Vladislav Shpilevoy
2020-03-26 17:51 ` Nikita Pettik
2020-04-03 14:13 ` Igor Munkin
2020-04-23 0:14 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55b7ae51-ddd9-cdce-ddc5-3c0e30942842@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/3] box: fix struct port_tuple.size wrong type in Lua' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox