Tarantool development patches archive
 help / color / mirror / Atom feed
From: "n.pettik" <korablev@tarantool.org>
To: Hollow111 <hollow653@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 2/2] sql: statistics removal after dropping an index
Date: Sat, 14 Apr 2018 11:13:24 +0300	[thread overview]
Message-ID: <55BEE14D-0F45-4DBD-95BB-D5EC23F02F18@tarantool.org> (raw)
In-Reply-To: <CAEi+_apaynDub6vGyVN=nkO=De6cRvFu-t6v72bCbUj0QcGGwQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]


> On 14 Apr 2018, at 07:29, Hollow111 <hollow653@gmail.com> wrote:
> 
> Hello. I'd like to ask about 'one kind of corrections”.

> 
> Arguments which you carry to the next line, should start right below previous:
> 
> void f(x int, ….
>           y char, ….
>           z double …);
> 
> I couldnt find this in  "C style guide" (https://tarantool.io/en/doc/2.0/dev_guide/c_style_guide.html <https://tarantool.io/en/doc/2.0/dev_guide/c_style_guide.html>)
> Moreover according to this guide:
> "Outside of comments, documentation and except in Kconfig, spaces are never used for indentation...".
> Which means we're supposed to violate this rule

In fact, they are used. Probably, we should update and clarify this point in docs.
You use tabs as much as possible. To precisely align argument lists, you have
to use spaces:

return_value very_long_function_name_bla_bla_bla(int first_argument,
						 int second_argument)

To make ’second_argument’ be under first, you should use 8 tabs + 1 space.
Overall, you can inspect other source files from box/ to understand how
source files should be formatted. Also, I advise you to make spaces and tabs visible.
For instance, see how it was done in box/space.c 106 : space_create()

> in case first argument is positioned not on the same range 
> from left corner of screen as any amount of 8-character tabs. 
> Maybe I'm wrong at smth but I'd like to have an explanation.


[-- Attachment #2: Type: text/html, Size: 4236 bytes --]

  reply	other threads:[~2018-04-14  8:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03 21:37 [tarantool-patches] " N.Tatunov
2018-04-04 14:06 ` [tarantool-patches] " n.pettik
2018-04-04 15:46   ` Hollow111
2018-04-04 16:11     ` n.pettik
2018-04-04 16:34       ` Hollow111
2018-04-05 18:01         ` n.pettik
     [not found]           ` <CAEi+_aq5oyeB0cbnxAXXjQqu=h+PCGaaZuLkk3p33yq371+Xog@mail.gmail.com>
2018-04-07  2:12             ` Hollow111
2018-04-09 12:16               ` n.pettik
2018-04-12  6:06                 ` Hollow111
2018-04-13  8:50                   ` n.pettik
2018-04-14  4:29                     ` Hollow111
2018-04-14  8:13                       ` n.pettik [this message]
2018-04-15  6:09                         ` Hollow111
2018-04-15  6:35                           ` Hollow111
2018-04-15 22:41                             ` n.pettik
2018-04-16 13:19                               ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55BEE14D-0F45-4DBD-95BB-D5EC23F02F18@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=hollow653@gmail.com \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 2/2] sql: statistics removal after dropping an index' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox