From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v3 1/4] sql: remove unnecessary AUTOINCREMENT ID generation
Date: Mon, 15 Jul 2019 20:50:36 +0300 [thread overview]
Message-ID: <55B5738A-FBB8-47E9-87F5-FA558ADAA785@tarantool.org> (raw)
In-Reply-To: <89267d98f7f336a5c76fd72e3888b83954b32f45.1562832978.git.imeevma@gmail.com>
>>> src/box/sql/insert.c | 5 +----
>>> test/sql/gh-2981-check-autoinc.result | 32 ++++++++++++++++++++++++++++++++
>>> test/sql/gh-2981-check-autoinc.test.lua | 11 ++++++++++-
>>> 3 files changed, 43 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/src/box/sql/insert.c b/src/box/sql/insert.c
>>> index b353148..d2b4e17 100644
>>> --- a/src/box/sql/insert.c
>>> +++ b/src/box/sql/insert.c
>>> @@ -628,10 +628,7 @@ sqlInsert(Parse * pParse, /* Parser context */
>>> if (j < 0 || nColumn == 0
>>> || (pColumn && j >= pColumn->nId)) {
>>> if (i == (int) autoinc_fieldno) {
>>> - sqlVdbeAddOp2(v,
>>> - OP_NextAutoincValue,
>>> - space->def->id,
>>> - iRegStore);
>>
>> Why didn’t you delete OP_NextAutioncValue?
>>
> I changed it functionality in the next patch.
You changes affect more than 50% of opcode's content.
Please, to make patches well structured, remove opcode
in current patch and resurrect in the next one.
next prev parent reply other threads:[~2019-07-15 17:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 8:22 [tarantool-patches] [PATCH v3 0/4] sql: do not show IDs generated by trigger imeevma
2019-07-11 8:22 ` [tarantool-patches] [PATCH v3 1/4] sql: remove unnecessary AUTOINCREMENT ID generation imeevma
2019-07-15 17:50 ` n.pettik [this message]
2019-07-11 8:22 ` [tarantool-patches] [PATCH v3 2/4] sql: do not show IDs generated by trigger imeevma
2019-07-15 17:50 ` [tarantool-patches] " n.pettik
2019-07-11 8:22 ` [tarantool-patches] [PATCH v3 3/4] sql: remove VDBE from TXN imeevma
2019-07-11 8:22 ` [tarantool-patches] [PATCH v3 4/4] sql: do not show generated IDs if INSERT failed imeevma
2019-07-11 8:52 ` [tarantool-patches] " Mergen Imeev
2019-07-15 17:59 ` n.pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B5738A-FBB8-47E9-87F5-FA558ADAA785@tarantool.org \
--to=korablev@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v3 1/4] sql: remove unnecessary AUTOINCREMENT ID generation' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox