From: Georgy Kirichenko <georgy@tarantool.org>
To: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] region: take allocated region size instead of used one
Date: Mon, 27 Jan 2020 23:26:02 +0300 [thread overview]
Message-ID: <5597526.lOV4Wx5bFT@localhost> (raw)
In-Reply-To: <20200127193320.33773-1-georgy@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
Sorry, I forgot an issue and a branch.
Issue: https://github.com/tarantool/tarantool/issues/4736
Branch: https://github.com/tarantool/tarantool/tree/g.kirichenko/gh-4736-region-size-for-gc
Also the branch was repushed because of wrong rebase.
On Monday, 27 January 2020 22:33:20 MSK Georgy Kirichenko wrote:
> As region has cached but not used slabs take the full region size
> in account while fiber gc.
>
> Fixes #4736
>
> diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c
> index 00ae8cded..f795dc566 100644
> --- a/src/lib/core/fiber.c
> +++ b/src/lib/core/fiber.c
> @@ -774,7 +774,7 @@ fiber_self()
> void
> fiber_gc(void)
> {
> - if (region_used(&fiber()->gc) < 128 * 1024) {
> + if (region_total(&fiber()->gc) < 128 * 1024) {
> region_reset(&fiber()->gc);
> return;
> }
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-27 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 19:33 Georgy Kirichenko
2020-01-27 20:26 ` Georgy Kirichenko [this message]
2020-01-29 21:50 ` Konstantin Osipov
2020-02-04 21:25 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5597526.lOV4Wx5bFT@localhost \
--to=georgy@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] region: take allocated region size instead of used one' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox