Re: [Tarantool-patches] [PATCH luajit 16/19] Prevent integer overflow while parsing long strings.

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, again

On 8/17/23 16:57, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
>
> On 17.08.23, Sergey Bronnikov wrote:
>> Hi, Sergey!
>>
>>
>> thanks for the patch!
>>
>> test duration is about 7 sec, I propose to add a print before string.rep:
>>
>> print('# test generation requires about 7 sec')
> I suppose it is a good thing to do, but there is another one test
> (gh-7745-oom-on-trace.test.lua) which takes a long time too.
> Maybe it's better to create a group of "long tests", or something like
> that. Also, we may introduce `test:comment()` helper which provides the
> same behaviour as the `test:diag('# ' .. fmt, ...)` and use it in all
> long tests. But I prefer to do it in the separate patch set, since this
> one is already huge enough :).
Okey, I'll not insist. LGTM
>
>> Otherwise it looks like test hang. Feel free to ignore.
>>
>>
>> LGTM after fixing comments from Max.
>>
>>
>> Sergey
> <snipped>
>