From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 393215C2EDC; Thu, 17 Aug 2023 17:28:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 393215C2EDC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692282534; bh=6Aw8AGbPmaudiBvvTsnDDt9kdk6j8W6s8uqZycn4d/Y=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Y0rHZuftpP4pAiHYMXhC1FFLeHJjSz+fNte6YqZWamhnjnxrKu9cdCh9pU/i0GRDE cAIKk7HahI+j75mkV9C+sFcX9U7U6ui1/B8hdwVoJOJNQibFu9eL0VwDh9JGfpq07A hwS0UAsOqWLN8kGkIdQn5iT9ZatW4IxvzyYdTy+A= Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [95.163.41.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 12E715C2843 for ; Thu, 17 Aug 2023 17:28:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 12E715C2843 Received: by smtp42.i.mail.ru with esmtpa (envelope-from ) id 1qWdzY-005Vrs-1J; Thu, 17 Aug 2023 17:28:52 +0300 Message-ID: <555f4a48-62ca-b341-91b5-ccfbe728db68@tarantool.org> Date: Thu, 17 Aug 2023 17:28:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Sergey Kaplun References: <713d9ff4-87ff-03a0-1f89-72b8b9b4b9d5@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D6BBDFD16DC5F73F29F7DA2AE4136AA2D182A05F538085040C7AE4624B86F4DC979EC8294695A4806D86D5E5D9497EC76D5D86572BC093DD5 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE701173C01F417A2A6EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637367CCE42412B8BE38638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8D2C318A258A355CB68881C6115519FFF117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3EA24FE487C076E5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F2CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE26055571C92BF10F6B91AC3BD56FC247D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE324D079F6B4507B166E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C2FFDA4F57982C5F42E808ACE2090B5E1725E5C173C3A84C3CF36E64A7E3F8E58089D37D7C0E48F6C8AA50765F79006373BA04B6A498D0BA4731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5147F14B41DD6F41568164E135394613CDE0984AC4959E9A9F87CCE6106E1FC07E67D4AC08A07B9B0735DFC8FA7AC1207CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34B9F55CA4D2956E308E41B2CD2E0842C39A30E1A181E022E24AE0CA32ECEB5C613AE62BB9F1C590EA1D7E09C32AA3244C4EABB97FA0C2ED86449A5EC3408360D2B4DF56057A86259FBAD658CF5C8AB4025DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFRrmMqSMPxr5CgXevgiDGA== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769DFDC15016DABD50879EC8294695A4806E8285F0AB37D98A7EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 16/19] Prevent integer overflow while parsing long strings. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, again On 8/17/23 16:57, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > > On 17.08.23, Sergey Bronnikov wrote: >> Hi, Sergey! >> >> >> thanks for the patch! >> >> test duration is about 7 sec, I propose to add a print before string.rep: >> >> print('# test generation requires about 7 sec') > I suppose it is a good thing to do, but there is another one test > (gh-7745-oom-on-trace.test.lua) which takes a long time too. > Maybe it's better to create a group of "long tests", or something like > that. Also, we may introduce `test:comment()` helper which provides the > same behaviour as the `test:diag('# ' .. fmt, ...)` and use it in all > long tests. But I prefer to do it in the separate patch set, since this > one is already huge enough :). Okey, I'll not insist. LGTM > >> Otherwise it looks like test hang. Feel free to ignore. >> >> >> LGTM after fixing comments from Max. >> >> >> Sergey > >