From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>, Sergey Bronnikov <sergeyb@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH luajit 31/36] test: enable <misc/tonumber_scan.lua> LuaJIT test Date: Wed, 14 Aug 2024 16:56:13 +0300 [thread overview] Message-ID: <54e05a4bf2de03cf389b6fdea8648f9e2d8bec78.1723638851.git.skaplun@tarantool.org> (raw) In-Reply-To: <cover.1723638851.git.skaplun@tarantool.org> This patch moves the aforementioned test from the <misc> to the <lib/base> directory, includes it in <index>, and names the subtest. Also, the NaN checks are skipped for parsing via `strtod()`, since LuaJIT uses canonicalized NaNs, which are equal to -NaN (0xfff8000000000000). Part of tarantool/tarantool#9398 --- test/LuaJIT-tests/lib/base/index | 1 + .../{misc => lib/base}/tonumber_scan.lua | 58 ++++++++++++------- 2 files changed, 37 insertions(+), 22 deletions(-) rename test/LuaJIT-tests/{misc => lib/base}/tonumber_scan.lua (93%) diff --git a/test/LuaJIT-tests/lib/base/index b/test/LuaJIT-tests/lib/base/index index 942c53c0..bef5dcb4 100644 --- a/test/LuaJIT-tests/lib/base/index +++ b/test/LuaJIT-tests/lib/base/index @@ -8,4 +8,5 @@ pairs.lua pcall_jit.lua select.lua tonumber_tostring.lua +tonumber_scan.lua +ffi xpcall_jit.lua +compat5.2 diff --git a/test/LuaJIT-tests/misc/tonumber_scan.lua b/test/LuaJIT-tests/lib/base/tonumber_scan.lua similarity index 93% rename from test/LuaJIT-tests/misc/tonumber_scan.lua rename to test/LuaJIT-tests/lib/base/tonumber_scan.lua index 78e1ca3e..e2dcd4d0 100644 --- a/test/LuaJIT-tests/misc/tonumber_scan.lua +++ b/test/LuaJIT-tests/lib/base/tonumber_scan.lua @@ -150,31 +150,45 @@ local function tohex64(x) return "0x"..bit.tohex(tonumber(x/2LL^32))..bit.tohex(tonumber(x%2LL^32)).."ULL" end -local conv = tonumber +local e = ffi.new("char *[1]") +local u = ffi.new("union { double d; uint64_t x; }") -if arg and arg[1] == "strtod" then - local e = ffi.new("char *[1]") - function conv(s) - local d = ffi.C.strtod(s, e) - return (e[0][0] == 0 and #s ~= 0) and d or nil +local function test_conv(conv, skip_nan) + for i = 1, #t, 2 do + local y, s = t[i], t[i + 1] + if s:lower():match('nan') and skip_nan then + -- LuaJIT uses canonicalized NaNs. + -- -NaN = 0xfff8000000000000. + -- Hence, `strtod()` yields a different value here. + goto continue + end + local d = conv(s) + local ok + if d == nil then + ok = (y == false) + else + u.d = d + ok = (y == u.x) + end + if not ok then + error(string.format( + "FAIL: '%s'\n\tGOT: %s\n\tOK: %s", + s, + d and tohex64(u.x) or "nil", + y and tohex64(y) or "nil", "\n\n" + )) + end + ::continue:: end end -local u = ffi.new("union { double d; uint64_t x; }") - -for i=1,#t,2 do - local y, s = t[i], t[i+1] - local d = conv(s) - local ok - if d == nil then - ok = (y == false) - else - u.d = d - ok = (y == u.x) - end - if not ok then - io.write('FAIL: "', s, '"\n GOT: ', d and tohex64(u.x) or "nil", " OK: ", y and tohex64(y) or "nil", "\n\n") --- print(" "..tohex64(u.x)..", \""..s.."\",") - end +do --- tonumber parsing + test_conv(tonumber) end +do --- strtod parsing + test_conv(function(s) + local d = ffi.C.strtod(s, e) + return (e[0][0] == 0 and #s ~= 0) and d or nil + end, true) +end -- 2.45.2
next prev parent reply other threads:[~2024-08-14 14:12 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-08-14 13:55 [Tarantool-patches] [PATCH luajit 00/36] Rearrange LuaJIT misc tests Sergey Kaplun via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 01/36] test: don't run JIT-based LuaJIT tests without JIT Sergey Kaplun via Tarantool-patches 2024-08-15 12:47 ` Sergey Bronnikov via Tarantool-patches 2024-08-19 8:47 ` Sergey Kaplun via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 02/36] test: enable <misc/alias_alloc.lua> LuaJIT test Sergey Kaplun via Tarantool-patches 2024-08-15 12:51 ` Sergey Bronnikov via Tarantool-patches 2024-08-15 13:31 ` Sergey Kaplun via Tarantool-patches 2024-08-30 7:25 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 03/36] test: refactor <lang/coroutine.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:00 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 04/36] test: remove <misc/coro_yield.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:05 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 05/36] test: enable <misc/debug_gc.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:09 ` Sergey Bronnikov via Tarantool-patches 2024-08-15 13:25 ` Sergey Kaplun via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 06/36] test: enable <misc/dualnum.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:11 ` Sergey Bronnikov via Tarantool-patches 2024-08-15 13:19 ` Sergey Bronnikov via Tarantool-patches 2024-08-15 13:22 ` Sergey Kaplun via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 07/36] test: remove <misc/fori_coerce.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:20 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 08/36] test: remove <misc/fori_dir.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:21 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 09/36] test: remove <misc/gc_rechain.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:22 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 10/36] test: enable <misc/gc_trace.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:24 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 11/36] test: enable <misc/gcstep.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:34 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 12/36] test: enable <misc/hook_active.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:38 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 13/36] test: enable <misc/hook_line.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:42 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 14/36] test: enable <misc/hook_norecord.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:56 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 15/36] test: enable <misc/hook_record.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:57 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 16/36] test: enable <misc/hook_top.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 17/36] test: enable <misc/jit_flush.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 18/36] test: remove <misc/loop_unroll.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 19/36] test: enable <misc/parse_comp.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 20/36] test: enable <misc/parse_esc.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 21/36] test: enable <misc/parse_misc.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 22/36] test: enable <misc/phi_conv.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 23/36] test: enable <misc/recurse_deep.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 24/36] test: remove <misc/recurse_tail.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 25/36] test: enable <misc/stack_gc.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 26/36] test: enable <misc/stack_purge.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 27/36] test: enable <misc/stackov.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 28/36] test: enable <misc/stackovc.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 29/36] test: enable <misc/tcall_base.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 30/36] test: enable <misc/tcall_loop.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` Sergey Kaplun via Tarantool-patches [this message] 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 32/36] test: remove <misc/uclo.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 33/36] test: enable <misc/unordered_jit.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 34/36] test: enable <misc/wbarrier.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 35/36] test: enable <misc/wbarrier_jit.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 36/36] test: enable <misc/wbarrier_obar.lua> " Sergey Kaplun via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=54e05a4bf2de03cf389b6fdea8648f9e2d8bec78.1723638851.git.skaplun@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 31/36] test: enable <misc/tonumber_scan.lua> LuaJIT test' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox