Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] Fix crash in case of lack of FDs during recovery
Date: Tue, 12 May 2020 22:53:57 +0200	[thread overview]
Message-ID: <541acd38-a41a-a3c5-33ce-8146eadb65cc@tarantool.org> (raw)
In-Reply-To: <cover.1588273848.git.korablev@tarantool.org>

Hi! Thanks for the patchset and the fixes!

LGTM.

On 30/04/2020 21:27, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/commits/np/gh-4805-too-many-fds
> Issue: https://github.com/tarantool/tarantool/issues/4805
> 
> First patch adds simple macro which allows error injection to be delayed.
> It also can be used in this series:
> https://lists.tarantool.org/pipermail/tarantool-patches/2020-April/016367.html
> 
> Nikita Pettik (2):
>   errinj: introduce delayed injection
>   vinyl: drop wasted runs in case range recovery fails
> 
>  src/box/vy_lsm.c                              |  14 ++-
>  src/box/vy_run.c                              |   4 +
>  src/errinj.h                                  |  10 ++
>  test/box/errinj.result                        |   1 +
>  test/vinyl/errinj_recovery.lua                |  10 ++
>  .../gh-4805-open-run-err-recovery.result      | 101 ++++++++++++++++++
>  .../gh-4805-open-run-err-recovery.test.lua    |  38 +++++++
>  test/vinyl/suite.ini                          |   2 +-
>  8 files changed, 176 insertions(+), 4 deletions(-)
>  create mode 100644 test/vinyl/errinj_recovery.lua
>  create mode 100644 test/vinyl/gh-4805-open-run-err-recovery.result
>  create mode 100644 test/vinyl/gh-4805-open-run-err-recovery.test.lua
> 

  parent reply	other threads:[~2020-05-12 20:53 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 19:27 Nikita Pettik
2020-04-30 19:27 ` [Tarantool-patches] [PATCH 1/2] errinj: introduce delayed injection Nikita Pettik
2020-04-30 20:15   ` Konstantin Osipov
2020-04-30 20:55     ` Nikita Pettik
2020-05-01 19:15       ` Konstantin Osipov
2020-05-03 19:20   ` Vladislav Shpilevoy
2020-05-07 13:50     ` Nikita Pettik
2020-05-07 21:47       ` Vladislav Shpilevoy
2020-05-07 22:41         ` Nikita Pettik
2020-04-30 19:27 ` [Tarantool-patches] [PATCH 2/2] vinyl: drop wasted runs in case range recovery fails Nikita Pettik
2020-05-03 19:21   ` Vladislav Shpilevoy
2020-05-07 13:02     ` Nikita Pettik
2020-05-07 14:16       ` Konstantin Osipov
2020-05-07 21:47         ` Vladislav Shpilevoy
2020-05-07 22:37           ` Nikita Pettik
2020-05-07 21:47       ` Vladislav Shpilevoy
2020-05-07 22:36         ` Nikita Pettik
2020-05-10 19:59           ` Vladislav Shpilevoy
2020-05-12  1:16             ` Nikita Pettik
2020-05-03 19:20 ` [Tarantool-patches] [PATCH 0/2] Fix crash in case of lack of FDs during recovery Vladislav Shpilevoy
2020-05-07 14:11   ` Nikita Pettik
2020-05-12 20:53 ` Vladislav Shpilevoy [this message]
2020-05-12 20:56   ` Vladislav Shpilevoy
2020-05-12 22:45     ` Nikita Pettik
2020-05-13 20:19       ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541acd38-a41a-a3c5-33ce-8146eadb65cc@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/2] Fix crash in case of lack of FDs during recovery' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox