From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>,
Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] cppcheck: box/alter.cc null pointer dereference
Date: Mon, 21 Sep 2020 22:15:10 +0200 [thread overview]
Message-ID: <539965bb-7c2b-6962-530f-d9494a71b260@tarantool.org> (raw)
In-Reply-To: <20200920175930.9016-1-skaplun@tarantool.org>
Hi! Thanks for the patch!
Commit title should be a subsystem name + description. Since we
don't have 'cppcheck' subsystem, I propose to use 'alter'.
LGTM except the commit title.
next prev parent reply other threads:[~2020-09-21 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 17:59 Sergey Kaplun
2020-09-21 20:15 ` Vladislav Shpilevoy [this message]
2020-09-21 20:37 ` Sergey Kaplun
2020-09-21 21:39 ` Vladislav Shpilevoy
2020-09-28 6:59 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539965bb-7c2b-6962-530f-d9494a71b260@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=skaplun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] cppcheck: box/alter.cc null pointer dereference' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox