Re: [Tarantool-patches] [PATCH luajit] codehealth: fix warnings for the codespell 2.3.0

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1881 bytes --]

Hi, Sergey

LGTM

On 10.03.2025 17:42, Sergey Kaplun wrote:
> This patch fixes the typo 'snapshoting' -> 'snapshotting' in the
> <lj-736-BC_UCLO-triggers-infinite-loop.test.lua>.
> Also, it adds `tru` and `fal` to the ignore list since they are used in
> the LuaJIT JIT dump output.
> ---
>
> Branch:https://github.com/tarantool/luajit/tree/skaplun/gh-no-ticket-codespell-2.3.0-fixes
> Note: CI is red due-to integrational testing problems.
> Seehttps://github.com/tarantool/tarantool/pull/11220.
>
>   .codespell-ignore-words.txt                                | 2 ++
>   .../lj-736-BC_UCLO-triggers-infinite-loop.test.lua         | 7 ++++---
>   2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/.codespell-ignore-words.txt b/.codespell-ignore-words.txt
> index 757ee53d..1fcceefa 100644
> --- a/.codespell-ignore-words.txt
> +++ b/.codespell-ignore-words.txt
> @@ -1,3 +1,5 @@
> +fal
>   fpr
>   isnt
>   nd
> +tru
> diff --git a/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua b/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
> index 01dba4bb..3f22c203 100644
> --- a/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
> +++ b/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
> @@ -35,9 +35,10 @@ local function testcase()
>   
>       -- Records the trace for which use-def analysis is applied.
>       for i = 1, 2 do
> -      -- This condition triggers snapshoting and use-def analysis.
> -      -- Before the patch this triggers the infinite loop in the
> -      -- `snap_usedef()`, so the `goto` is never taken.
> +      -- This condition triggers snapshotting and use-def
> +      -- analysis. Before the patch this triggers the infinite
> +      -- loop in the `snap_usedef()`, so the `goto` is never
> +      -- taken.
>         if i == 2 then
>           goto x
>         end

[-- Attachment #2: Type: text/html, Size: 2489 bytes --]