From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v1] gitlab-ci: restore lto testing on OSX
Date: Tue, 28 Jul 2020 18:09:14 +0300 [thread overview]
Message-ID: <5358833fffe09a551632732d6e63af36768647e3.1595947426.git.avtikhon@tarantool.org> (raw)
Found that after commit:
7faa1abe2b2dedd3a5d2971ddd7c5b9ce55c30b2 "gitlab-ci: implement OSX 10.14 testing on mac mini"
the variable environment CMAKE_EXTRA_PARAMS, which turns on LTO flag
on OSX compilation was mistakenly missed to be updated and LTO feature
was disabled on OSX testing in real.
After it later commit:
a94a9b3fd629b5abbc99a23ba527cd91e5c6ebf5 "lua/log: add ability to configure logging early"
added the missed LTO error, which was fixed at:
625095d95c5d1962c02c124fcba098e527f017fd "lua/log: add missing exports"
Closes #5160
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5160-restore-osx-lto
Issue: https://github.com/tarantool/tarantool/issues/5160
.gitlab-ci.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 580825005..0ead08711 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -194,7 +194,7 @@ osx_15_release_lto:
tags:
- osx_15
variables:
- EXTRA_ENV: 'export CMAKE_EXTRA_PARAMS=-DENABLE_LTO=ON ;'
+ CMAKE_EXTRA_PARAMS: -DENABLE_LTO=ON
<<: *osx_definition
freebsd_12_release:
--
2.17.1
next reply other threads:[~2020-07-28 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 15:09 Alexander V. Tikhonov [this message]
2020-07-28 15:42 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5358833fffe09a551632732d6e63af36768647e3.1595947426.git.avtikhon@tarantool.org \
--to=avtikhon@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] gitlab-ci: restore lto testing on OSX' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox