Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: imeevma@tarantool.org, tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v8 4/6] lua: create method dump_lua for port_sql
Date: Tue, 29 Jan 2019 23:42:25 +0300	[thread overview]
Message-ID: <534a3bdb-b245-ef71-69b5-4ec134f01c7c@tarantool.org> (raw)
In-Reply-To: <c2e21045eb2d3ca7e61e3c91510ea80248471e25.1547902954.git.imeevma@gmail.com>

Thanks for the patch! See 2 comments below.

> commit 78e3d54239d51ad52ebf377acb016c66426299ec
> Author: Mergen Imeev <imeevma@gmail.com>
> Date:   Fri Dec 21 16:48:37 2018 +0300
> 
>      lua: create method dump_lua for port_sql
>      
>      This patch creates the dump_lua method for port_sql. It also
>      defines a new function box.sql.new_execute(), which will be
>      converted to box.sql.execute().
>      
>      Part of ...3505
> 

1. Please, replace ... with # in all patches, as I asked in the
review of the first commit.

2. I think, that it is time to finally finish this patchset
and remove "new_execute" from this commit, and in the
last commit replace "sql.execute" with "execute".

  reply	other threads:[~2019-01-29 20:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-19 13:20 [tarantool-patches] [PATCH v8 0/6] sql: remove box.sql.execute imeevma
2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 1/6] lua: remove exceptions from function luaL_tofield() imeevma
2019-01-22 19:58   ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-24  7:27     ` Imeev Mergen
2019-01-29 20:42   ` Vladislav Shpilevoy
2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 2/6] iproto: move map creation to sql_response_dump() imeevma
2019-01-25 16:07   ` [tarantool-patches] " Konstantin Osipov
2019-01-29 20:42     ` Vladislav Shpilevoy
2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 3/6] iproto: create port_sql imeevma
2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 4/6] lua: create method dump_lua for port_sql imeevma
2019-01-29 20:42   ` Vladislav Shpilevoy [this message]
2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 5/6] lua: parameter binding for new execute() imeevma
2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 6/6] sql: check new box.sql.execute() imeevma
2019-01-22 19:58 ` [tarantool-patches] Re: [PATCH v8 0/6] sql: remove box.sql.execute Vladislav Shpilevoy
2019-01-24  7:31   ` Imeev Mergen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534a3bdb-b245-ef71-69b5-4ec134f01c7c@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v8 4/6] lua: create method dump_lua for port_sql' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox