From: Oleg Babin <olegrok@tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 2/2] uuid: support uuid comparison with strings
Date: Tue, 24 Nov 2020 22:23:11 +0300 [thread overview]
Message-ID: <52a36f3c-b886-044b-d0ba-e8cb30e37a31@tarantool.org> (raw)
In-Reply-To: <20201124152054.GF14086@tarantool.org>
Thanks for review!
On 24/11/2020 18:20, Igor Munkin wrote:
> Oleg,
>
> Thanks for the patch! Considering the version on the remote branch, LGTM
> except a single nit below.
>
> On 18.11.20,olegrok@tarantool.org wrote:
>> From: Oleg Babin<babinoleg@mail.ru>
>>
>> Before this patch it was impossible to compare uuid values with
>> string representations of uuid. However we have cases when such
>> comparisons is possible (e.g. "decimal" where we can compare
>> decimal values with strings and numbers).
>>
>> This patch extends uuid comparators (eq, lt, le) and every string
> Minor: Strictly saying, you're right, but AFAICS we usually use the key
> name (i.e. __eq, __le and __lt) for metamethods in description.
I've updated and force-pushed branch. I cite only changed part:
This patch extends uuid comparators (__eq, __lt and __le) and
every string argument is tried to be converted to uuid value to
compare then.
next prev parent reply other threads:[~2020-11-24 19:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 7:56 [Tarantool-patches] [PATCH v2 0/2] Make uuid values comparable olegrok
2020-11-18 7:56 ` [Tarantool-patches] [PATCH v2 1/2] uuid: support comparison of uuid values in Lua olegrok
2020-11-21 15:17 ` Vladislav Shpilevoy
2020-11-21 19:07 ` Oleg Babin
2020-11-23 21:58 ` Vladislav Shpilevoy
2020-11-24 5:57 ` Oleg Babin
2020-11-24 13:06 ` Igor Munkin
2020-11-27 15:17 ` Oleg Babin
2020-11-24 15:20 ` Igor Munkin
2020-11-24 19:23 ` Oleg Babin
2020-11-18 7:56 ` [Tarantool-patches] [PATCH v2 2/2] uuid: support uuid comparison with strings olegrok
2020-11-21 15:17 ` Vladislav Shpilevoy
2020-11-21 19:07 ` Oleg Babin
2020-11-24 15:20 ` Igor Munkin
2020-11-24 19:23 ` Oleg Babin [this message]
2020-11-18 8:02 ` [Tarantool-patches] [PATCH v2 0/2] Make uuid values comparable Oleg Babin
2020-11-27 22:39 ` Vladislav Shpilevoy
2020-11-27 22:40 ` Vladislav Shpilevoy
2020-12-04 8:13 ` Oleg Babin
2020-12-07 23:04 ` Alexander V. Tikhonov
2020-12-07 23:24 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52a36f3c-b886-044b-d0ba-e8cb30e37a31@tarantool.org \
--to=olegrok@tarantool.org \
--cc=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 2/2] uuid: support uuid comparison with strings' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox