From: Imeev Mergen <imeevma@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v8 1/6] lua: remove exceptions from function luaL_tofield()
Date: Thu, 24 Jan 2019 10:27:30 +0300 [thread overview]
Message-ID: <528bcc65-97ed-c6c3-d71a-7d55e0e3cc31@tarantool.org> (raw)
In-Reply-To: <c72792bf-f5bb-e7fe-8277-0498a1284e05@tarantool.org>
Hi! Thank you for comments. My answers below.
On 1/22/19 10:58 PM, Vladislav Shpilevoy wrote:
> Thanks for the fixes!
>
>> Diff between versions:
>>
>> commit 07bcff72336fe861fd51d895fe088662a9d09fe4
>> Author: Mergen Imeev <imeevma@gmail.com>
>> Date: Thu Jan 17 15:00:27 2019 +0300
>>
>> Temporary: Review fixes
>
> Please, do not merge diff of all comments into a single one. It
> is hardly possible to restore which part of this diff corresponds
> to which comment. Inline diff, fixing one comment, under this comment,
> like Nikita does.
>
> Also, I see that the branch still stores the old patchset. Please,
> push it. Until that I can not review it.
Ok, understood.
>
>> commit 3080ab1d7d2e8d8716ac91fc71150db7cde4ffe4
>> Author: Mergen Imeev <imeevma@gmail.com>
>> Date: Fri Jan 11 21:16:12 2019 +0300
>>
>> lua: remove exceptions from function luaL_tofield()
>> Before this commit, the luaL_tofield() function threw a Lua
>> exception when an error occurred. This behavior has been changed
>> in this commit, now it sets diag_set() and returns -1 in case of
>> an error.
>> Needed for ...3505
>
> Please, use #, not ... .
Sorry, I actually wrote wrong branch name. Right branch is:
https://github.com/tarantool/tarantool/tree/imeevma/gh-3505-replace-box_sql_execute-by-box_execute
next prev parent reply other threads:[~2019-01-24 7:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 13:20 [tarantool-patches] [PATCH v8 0/6] sql: remove box.sql.execute imeevma
2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 1/6] lua: remove exceptions from function luaL_tofield() imeevma
2019-01-22 19:58 ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-24 7:27 ` Imeev Mergen [this message]
2019-01-29 20:42 ` Vladislav Shpilevoy
2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 2/6] iproto: move map creation to sql_response_dump() imeevma
2019-01-25 16:07 ` [tarantool-patches] " Konstantin Osipov
2019-01-29 20:42 ` Vladislav Shpilevoy
2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 3/6] iproto: create port_sql imeevma
2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 4/6] lua: create method dump_lua for port_sql imeevma
2019-01-29 20:42 ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 5/6] lua: parameter binding for new execute() imeevma
2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 6/6] sql: check new box.sql.execute() imeevma
2019-01-22 19:58 ` [tarantool-patches] Re: [PATCH v8 0/6] sql: remove box.sql.execute Vladislav Shpilevoy
2019-01-24 7:31 ` Imeev Mergen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528bcc65-97ed-c6c3-d71a-7d55e0e3cc31@tarantool.org \
--to=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v8 1/6] lua: remove exceptions from function luaL_tofield()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox