From: "n.pettik" <korablev@tarantool.org> To: tarantool-patches@freelists.org Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org> Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: triggers on view unfinished updates Date: Thu, 16 Aug 2018 16:45:09 +0300 [thread overview] Message-ID: <523E8244-AC85-4EE1-B08F-047EC74FAFA7@tarantool.org> (raw) In-Reply-To: <d216d3e7d529c4e3d8e91daa85b7282a26c67580.1534425929.git.kshcherbatov@tarantool.org> > Excepting primary index is a typical thing for view so Nitpicking: not ‘excepting’ but lack of I guess. > we should use space_index instead of index_find that doesn't > setup diag error when no index is finded. > > Closes #3536. > --- > diff --git a/test/sql/triggers.test.lua b/test/sql/triggers.test.lua > index 8fd385c..fff58e9 100644 > --- a/test/sql/triggers.test.lua > +++ b/test/sql/triggers.test.lua > @@ -142,3 +142,17 @@ box.sql.execute("SELECT * FROM test2") > box.sql.execute("ROLLBACK;") > box.sql.execute("DROP TABLE test;") > box.sql.execute("DROP TABLE test2;") > + > +-- > +-- gh-3536: Some triggers cause error messages and/or half-finished updates > +-- > +box.cfg{} Why do you need to call box.cfg{} here?
next prev parent reply other threads:[~2018-08-16 13:45 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-16 13:26 [tarantool-patches] " Kirill Shcherbatov 2018-08-16 13:45 ` n.pettik [this message] 2018-08-16 13:49 ` [tarantool-patches] " Kirill Shcherbatov 2018-08-16 13:57 ` Vladislav Shpilevoy 2018-08-16 14:04 ` Kirill Shcherbatov 2018-08-16 14:41 ` n.pettik 2018-08-17 6:30 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=523E8244-AC85-4EE1-B08F-047EC74FAFA7@tarantool.org \ --to=korablev@tarantool.org \ --cc=kshcherbatov@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: triggers on view unfinished updates' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox