From: Oleg Babin <olegrok@tarantool.org> To: Leonid Vasiliev <lvasiliev@tarantool.org>, Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v4 7/8] lua/log: allow to configure logging without a box Date: Fri, 29 May 2020 11:53:45 +0300 [thread overview] Message-ID: <51ab9c83-4392-b5bd-49ac-652b1892afa0@tarantool.org> (raw) In-Reply-To: <19d91eba-a988-0ee8-6c1b-1b83dca9fce8@tarantool.org> Hi! It's ok I think. box.cfg table stores user-defined values. But it's a good point. There is an example of similar behaviour[1]: ``` tarantool> box.cfg{listen = 0} --- ... tarantool> box.cfg.listen --- - '0' ... tarantool> box.info.listen --- - '[::]:64991' ... ``` box.cfg.listen is "0" because you acually specify it by hands. box.info.listen is real value of property. My point in such case don't try to support consistency between box.cfg and log.cfg. But: - log.cfg should always store an actual value of parameters - box.info (maybe, but not box.cfg) should also do it. I hope it's appropriate stay it as is but file an issue to fix such it in future. It won't breaking change for existing installations (that doesn't use log.cfg{}) [1] https://github.com/tarantool/tarantool/issues/4620 On 29/05/2020 11:41, Leonid Vasiliev wrote: > Hi! Thank you for the patch. > See some comments below. ... > > tarantool> log.cfg{log_level = 2} > --- > ... > > tarantool> box.cfg.log_level > --- > - 3 > ... > > tarantool> log.cfg.log_level > --- > - 2 > ...
next prev parent reply other threads:[~2020-05-29 8:53 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-28 10:07 [Tarantool-patches] [PATCH v4 0/8] lua/log: add an ability to setup logger without box.cfg{} Cyrill Gorcunov 2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 1/8] core/say: do not reconfig early set up logger Cyrill Gorcunov 2020-05-28 10:36 ` Oleg Babin 2020-05-28 10:42 ` lvasiliev 2020-05-28 10:47 ` Cyrill Gorcunov 2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 2/8] lua/log: declare say_logger_init and say_logger_initialized Cyrill Gorcunov 2020-05-28 10:37 ` Oleg Babin 2020-05-28 11:12 ` lvasiliev 2020-05-28 11:16 ` Cyrill Gorcunov 2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 3/8] lua/log: put string constants to map Cyrill Gorcunov 2020-05-28 10:37 ` Oleg Babin 2020-05-28 12:46 ` lvasiliev 2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 4/8] lua/log: do not allow to set json for boot logger Cyrill Gorcunov 2020-05-28 10:40 ` Oleg Babin 2020-05-28 10:48 ` Cyrill Gorcunov 2020-05-28 11:49 ` lvasiliev 2020-05-28 11:59 ` Cyrill Gorcunov 2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 5/8] lua/log: declare log as separate variable Cyrill Gorcunov 2020-05-28 10:40 ` Oleg Babin 2020-05-28 12:57 ` lvasiliev 2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 6/8] lua/log: use log module settings inside box.cfg Cyrill Gorcunov 2020-05-28 10:41 ` Oleg Babin 2020-05-28 10:49 ` Cyrill Gorcunov 2020-05-28 17:07 ` lvasiliev 2020-05-28 17:34 ` Cyrill Gorcunov 2020-05-29 8:43 ` Leonid Vasiliev 2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 7/8] lua/log: allow to configure logging without a box Cyrill Gorcunov 2020-05-28 10:42 ` Oleg Babin 2020-05-29 8:41 ` Leonid Vasiliev 2020-05-29 8:53 ` Oleg Babin [this message] 2020-05-29 9:16 ` Leonid Vasiliev 2020-05-29 9:49 ` Cyrill Gorcunov 2020-05-29 10:00 ` Oleg Babin 2020-05-29 10:22 ` Leonid Vasiliev 2020-05-29 10:38 ` Cyrill Gorcunov 2020-05-29 11:08 ` Leonid Vasiliev 2020-05-29 11:32 ` Cyrill Gorcunov 2020-05-29 11:39 ` Leonid Vasiliev 2020-05-29 10:07 ` Cyrill Gorcunov 2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 8/8] test: use direct log module Cyrill Gorcunov 2020-05-28 10:42 ` Oleg Babin 2020-05-28 10:50 ` Cyrill Gorcunov 2020-05-29 9:02 ` Leonid Vasiliev 2020-05-29 11:31 ` [Tarantool-patches] [PATCH v4 0/8] lua/log: add an ability to setup logger without box.cfg{} Leonid Vasiliev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=51ab9c83-4392-b5bd-49ac-652b1892afa0@tarantool.org \ --to=olegrok@tarantool.org \ --cc=gorcunov@gmail.com \ --cc=lvasiliev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v4 7/8] lua/log: allow to configure logging without a box' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox