[tarantool-patches] Re: [PATCH v4 5/6] sql: move Triggers to server

[Kirill Shcherbatov <kshcherbatov@tarantool.org>]

> Now it is possible to delete trigger using only its name, since
> in on_replace_dd_trigger() we would have space_id from tuple.
> So, we came to agreement to delete global hash of triggers.
I'll send a patch.

> It would be great if you provided diff: right here, at the end of letter or
> as a next patch version. Don’t forget next time.
Ok, I'll try do not forget next time.

> Please, sent that patch or attach diff.
I'll send a patch.

> Add cautionary (or FIXME) comment which would explain that
> in case of RENAME’s fail we are totally fucked up: part of triggers
> remain with old space’s name. Thus, after creation of new space with
> the name of old one, it appears with triggers which haven’t been created.
+                       /*
+                        * FIXME: In the case of error,
+                        * part of triggers would have invalid
+                        * space name in tuple so can not been
+                        * persisted.
+                        * Server could be restarted.
+                        * In this case, rename table back and
+                        * try again.
+                        */