Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: "Alexander V. Tikhonov" <avtikhon@tarantool.org>,
	tarantool-patches@freelists.org
Subject: [PATCH v1] test: box/net.box test flaky fails on grep_log
Date: Tue,  9 Jul 2019 18:14:57 +0300	[thread overview]
Message-ID: <50f5ce55066136d531ff10e0cdecd0fb964098c2.1562685274.git.avtikhon@tarantool.org> (raw)

box/net.box test flaky failed on grepping the log file
for 'ER_NO_SUCH_PROC' pattern on high load running hosts,
found that the issue can be resolved by updating the
grep_log to wait_log function to make able to wait the
needed message for some time.

[008] Test failed! Result content mismatch:
[008] --- box/net.box.result	Tue Jul  9 17:00:24 2019
[008] +++ box/net.box.reject	Tue Jul  9 17:03:34 2019
[008] @@ -1376,7 +1376,7 @@
[008]  ...
[008]  test_run:grep_log("default", "ER_NO_SUCH_PROC")
[008]  ---
[008] -- ER_NO_SUCH_PROC
[008] +- null
[008]  ...
[008]  box.schema.user.revoke('guest', 'execute', 'universe')
[008]  ---

Closes #4329
---
 test/box/net.box.result   | 2 +-
 test/box/net.box.test.lua | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/box/net.box.result b/test/box/net.box.result
index a18546d12..8b623cde3 100644
--- a/test/box/net.box.result
+++ b/test/box/net.box.result
@@ -1374,7 +1374,7 @@ test_run:cmd("setopt delimiter ''");
 ---
 - true
 ...
-test_run:grep_log("default", "ER_NO_SUCH_PROC")
+test_run:wait_log('default', 'ER_NO_SUCH_PROC', nil, 10)
 ---
 - ER_NO_SUCH_PROC
 ...
diff --git a/test/box/net.box.test.lua b/test/box/net.box.test.lua
index 07558a0dc..aba634c6d 100644
--- a/test/box/net.box.test.lua
+++ b/test/box/net.box.test.lua
@@ -537,7 +537,7 @@ _ = fiber.create(
    end
 );
 test_run:cmd("setopt delimiter ''");
-test_run:grep_log("default", "ER_NO_SUCH_PROC")
+test_run:wait_log('default', 'ER_NO_SUCH_PROC', nil, 10)
 box.schema.user.revoke('guest', 'execute', 'universe')
 
 --
-- 
2.17.1

                 reply	other threads:[~2019-07-09 15:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50f5ce55066136d531ff10e0cdecd0fb964098c2.1562685274.git.avtikhon@tarantool.org \
    --to=avtikhon@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH v1] test: box/net.box test flaky fails on grep_log' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox