From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org,
Nikita Pettik <korablev@tarantool.org>,
Konstantin Osipov <kostja.osipov@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v1 0/9] schema: rework _trigger space
Date: Wed, 16 Oct 2019 15:53:07 +0300 [thread overview]
Message-ID: <50e10b12-31a5-cfc0-d4ac-76d66512db43@tarantool.org> (raw)
In-Reply-To: <20191016121811.GA12432@tarantool.org>
> - name (both have)
> - func_id (only Lua)
> - space_id (both have)
> - type (means one of replace/connection/auth etc; only Lua)
> - event (only SQL)
> - action_time (SQL and Lua have sets of timings which don't intersect)
> - action (only SQL)
I need to mention that I didn't followed this outdated proposal in the
refactoring that we are discussing.
<name> STRING (both have)
<space_id> UINT32 (both have)
<opts> MAP (non of them for now, legacy, but potentially usefull)
<language> STR (both have)
<type> STR (both have; currently 'replace' type only - replace trigger;
perhaps we would like to support some different trigger types)
<event_manipulation> STR {"DELETE", "UPDATE", "INSERT" --
SQL only? - but it is possible to support it in Lua also}
<action_timing> STR {"BEFORE", "AFTER" - both have}
<code> STR (both have)
next prev parent reply other threads:[~2019-10-16 12:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 16:03 [Tarantool-patches] " Kirill Shcherbatov
2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 1/9] sql: remove redundant pointer in TriggerStep Kirill Shcherbatov
2019-10-15 15:35 ` [Tarantool-patches] [tarantool-patches] " Nikita Pettik
2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 2/9] box: rename struct trigger to lua_trigger Kirill Shcherbatov
2019-10-17 7:33 ` Konstantin Osipov
2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 3/9] box: introduce trigger_event_manipulation enum Kirill Shcherbatov
2019-10-17 7:35 ` Konstantin Osipov
2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 4/9] box: introduce trigger_action_timing enum Kirill Shcherbatov
2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 5/9] sql: use rlist to organize triggers in a list Kirill Shcherbatov
2019-10-17 7:36 ` Konstantin Osipov
2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 6/9] sql: rework CREATE TABLE rule in parser Kirill Shcherbatov
2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 7/9] sql: wrap all ASTs in sql_trigger_expr structure Kirill Shcherbatov
2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 8/9] sql: inherit sql_trigger from a new trigger class Kirill Shcherbatov
2019-10-17 7:38 ` Konstantin Osipov
2019-10-14 16:03 ` [Tarantool-patches] [PATCH v1 9/9] schema: rework _trigger system space Kirill Shcherbatov
2019-10-17 7:44 ` Konstantin Osipov
2019-10-15 21:34 ` [Tarantool-patches] [tarantool-patches] [PATCH v1 0/9] schema: rework _trigger space Nikita Pettik
2019-10-16 5:57 ` Konstantin Osipov
2019-10-16 5:58 ` Konstantin Osipov
2019-10-16 11:07 ` Nikita Pettik
2019-10-16 11:11 ` Konstantin Osipov
2019-10-16 12:18 ` Nikita Pettik
2019-10-16 12:32 ` Konstantin Osipov
2019-10-16 12:47 ` Nikita Pettik
2019-10-16 12:53 ` Konstantin Osipov
2019-10-16 13:13 ` Nikita Pettik
2019-10-16 14:18 ` Konstantin Osipov
2019-10-16 12:53 ` Kirill Shcherbatov [this message]
2019-10-16 13:31 ` [Tarantool-patches] [tarantool-patches] " Nikita Pettik
2019-10-16 13:47 ` Kirill Shcherbatov
2019-10-16 20:27 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50e10b12-31a5-cfc0-d4ac-76d66512db43@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=korablev@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v1 0/9] schema: rework _trigger space' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox