From: lvasiliev <lvasiliev@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 1/8] core/say: do not reconfig early set up logger
Date: Thu, 28 May 2020 13:42:01 +0300 [thread overview]
Message-ID: <50a32f08-7cb0-bfe0-c63f-da91d6e7331b@tarantool.org> (raw)
In-Reply-To: <20200528100738.221911-2-gorcunov@gmail.com>
Hi! Thank you for the patch.
I have a minor comment that can be skipped silently.
> diff --git a/src/lib/core/say.h b/src/lib/core/say.h
> index c50d7bbf4..857145465 100644
> --- a/src/lib/core/say.h
> +++ b/src/lib/core/say.h
> @@ -274,6 +274,10 @@ say_logger_init(const char *init_str,
> const char *log_format,
> int background);
>
> +/** Test if logger is initialized. */
> +bool
> +say_logger_initialized(void);
> +
I think this function may be used for the check in say_logger_free()
instead log_default == &log_std.
> /** Free default logger */
> void
> say_logger_free();
>
next prev parent reply other threads:[~2020-05-28 10:42 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 10:07 [Tarantool-patches] [PATCH v4 0/8] lua/log: add an ability to setup logger without box.cfg{} Cyrill Gorcunov
2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 1/8] core/say: do not reconfig early set up logger Cyrill Gorcunov
2020-05-28 10:36 ` Oleg Babin
2020-05-28 10:42 ` lvasiliev [this message]
2020-05-28 10:47 ` Cyrill Gorcunov
2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 2/8] lua/log: declare say_logger_init and say_logger_initialized Cyrill Gorcunov
2020-05-28 10:37 ` Oleg Babin
2020-05-28 11:12 ` lvasiliev
2020-05-28 11:16 ` Cyrill Gorcunov
2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 3/8] lua/log: put string constants to map Cyrill Gorcunov
2020-05-28 10:37 ` Oleg Babin
2020-05-28 12:46 ` lvasiliev
2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 4/8] lua/log: do not allow to set json for boot logger Cyrill Gorcunov
2020-05-28 10:40 ` Oleg Babin
2020-05-28 10:48 ` Cyrill Gorcunov
2020-05-28 11:49 ` lvasiliev
2020-05-28 11:59 ` Cyrill Gorcunov
2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 5/8] lua/log: declare log as separate variable Cyrill Gorcunov
2020-05-28 10:40 ` Oleg Babin
2020-05-28 12:57 ` lvasiliev
2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 6/8] lua/log: use log module settings inside box.cfg Cyrill Gorcunov
2020-05-28 10:41 ` Oleg Babin
2020-05-28 10:49 ` Cyrill Gorcunov
2020-05-28 17:07 ` lvasiliev
2020-05-28 17:34 ` Cyrill Gorcunov
2020-05-29 8:43 ` Leonid Vasiliev
2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 7/8] lua/log: allow to configure logging without a box Cyrill Gorcunov
2020-05-28 10:42 ` Oleg Babin
2020-05-29 8:41 ` Leonid Vasiliev
2020-05-29 8:53 ` Oleg Babin
2020-05-29 9:16 ` Leonid Vasiliev
2020-05-29 9:49 ` Cyrill Gorcunov
2020-05-29 10:00 ` Oleg Babin
2020-05-29 10:22 ` Leonid Vasiliev
2020-05-29 10:38 ` Cyrill Gorcunov
2020-05-29 11:08 ` Leonid Vasiliev
2020-05-29 11:32 ` Cyrill Gorcunov
2020-05-29 11:39 ` Leonid Vasiliev
2020-05-29 10:07 ` Cyrill Gorcunov
2020-05-28 10:07 ` [Tarantool-patches] [PATCH v4 8/8] test: use direct log module Cyrill Gorcunov
2020-05-28 10:42 ` Oleg Babin
2020-05-28 10:50 ` Cyrill Gorcunov
2020-05-29 9:02 ` Leonid Vasiliev
2020-05-29 11:31 ` [Tarantool-patches] [PATCH v4 0/8] lua/log: add an ability to setup logger without box.cfg{} Leonid Vasiliev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50a32f08-7cb0-bfe0-c63f-da91d6e7331b@tarantool.org \
--to=lvasiliev@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4 1/8] core/say: do not reconfig early set up logger' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox