From: Stanislav Zudin <szudin@tarantool.org> To: tarantool-patches@freelists.org, vdavydov.dev@gmail.com Cc: Stanislav Zudin <szudin@tarantool.org> Subject: [PATCH 05/13] sql: removes redundant function. Date: Fri, 15 Mar 2019 18:45:34 +0300 [thread overview] Message-ID: <5080d8b28aed2d2ae14bcf709ddcf65d43be797b.1552663061.git.szudin@tarantool.org> (raw) In-Reply-To: <cover.1552663061.git.szudin@tarantool.org> In-Reply-To: <cover.1552663061.git.szudin@tarantool.org> --- src/box/execute.c | 2 -- src/box/lua/sql.c | 2 -- src/box/sql/sqlInt.h | 3 --- src/box/sql/vdbeapi.c | 8 -------- 4 files changed, 15 deletions(-) diff --git a/src/box/execute.c b/src/box/execute.c index 31b89a75e..210b9a228 100644 --- a/src/box/execute.c +++ b/src/box/execute.c @@ -241,7 +241,6 @@ sql_column_to_messagepack(struct sql_stmt *stmt, int i, int type = sql_column_type(stmt, i); switch (type) { case SQL_INTEGER: { - assert(!sql_column_is_unsigned(stmt, i)); int64_t n = sql_column_int64(stmt, i); if (n >= 0) size = mp_sizeof_uint(n); @@ -257,7 +256,6 @@ sql_column_to_messagepack(struct sql_stmt *stmt, int i, break; } case SQL_UNSIGNED: { - assert(sql_column_is_unsigned(stmt, i)); int64_t n = sql_column_int64(stmt, i); size = mp_sizeof_uint(n); char *pos = (char *) region_alloc(region, size); diff --git a/src/box/lua/sql.c b/src/box/lua/sql.c index 9a35c03aa..76bb44fa1 100644 --- a/src/box/lua/sql.c +++ b/src/box/lua/sql.c @@ -32,11 +32,9 @@ lua_push_row(struct lua_State *L, struct sql_stmt *stmt) int type = sql_column_type(stmt, i); switch (type) { case SQL_INTEGER: - assert(!sql_column_is_unsigned(stmt, i)); luaL_pushint64(L, sql_column_int64(stmt, i)); break; case SQL_UNSIGNED: - assert(sql_column_is_unsigned(stmt, i)); luaL_pushuint64(L, sql_column_int64(stmt, i)); break; case SQL_FLOAT: diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h index 56aa7c681..9b1d7df9a 100644 --- a/src/box/sql/sqlInt.h +++ b/src/box/sql/sqlInt.h @@ -586,9 +586,6 @@ sql_column_text(sql_stmt *, int sql_column_type(sql_stmt *, int iCol); -bool -sql_column_is_unsigned(sql_stmt *, int iCol); - sql_value * sql_column_value(sql_stmt *, int iCol); diff --git a/src/box/sql/vdbeapi.c b/src/box/sql/vdbeapi.c index 2c486552e..c3bdb6f86 100644 --- a/src/box/sql/vdbeapi.c +++ b/src/box/sql/vdbeapi.c @@ -1085,14 +1085,6 @@ sql_column_type(sql_stmt * pStmt, int i) return iType; } -bool sql_column_is_unsigned(sql_stmt * pStmt, int i) -{ - const struct Mem* pMem = columnMem(pStmt, i); - if (!pMem) - return false; - return (pMem->flags & MEM_Unsigned); -} - enum sql_subtype sql_column_subtype(struct sql_stmt *stmt, int i) { -- 2.17.1
next prev parent reply other threads:[~2019-03-15 15:45 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-15 15:45 [PATCH 00/13] sql: support -2^63 .. 2^64-1 integer type Stanislav Zudin 2019-03-15 15:45 ` [PATCH 01/13] sql: Convert big integers from string Stanislav Zudin 2019-03-25 15:10 ` [tarantool-patches] " n.pettik 2019-04-01 20:39 ` Stanislav Zudin 2019-04-02 7:27 ` Konstantin Osipov 2019-03-15 15:45 ` [PATCH 02/13] sql: make VDBE recognize big integers Stanislav Zudin 2019-03-25 15:11 ` [tarantool-patches] " n.pettik 2019-04-01 20:42 ` Stanislav Zudin 2019-04-02 7:38 ` [tarantool-patches] " Konstantin Osipov 2019-03-15 15:45 ` [PATCH 03/13] sql: removes unused function Stanislav Zudin 2019-03-25 15:11 ` [tarantool-patches] " n.pettik 2019-04-01 20:39 ` Stanislav Zudin 2019-03-15 15:45 ` [PATCH 04/13] sql: support big integers within sql binding Stanislav Zudin 2019-03-25 15:12 ` [tarantool-patches] " n.pettik 2019-04-01 20:42 ` Stanislav Zudin 2019-04-02 7:46 ` Konstantin Osipov 2019-04-02 7:44 ` [tarantool-patches] " Konstantin Osipov 2019-03-15 15:45 ` Stanislav Zudin [this message] 2019-03-25 15:12 ` [tarantool-patches] Re: [PATCH 05/13] sql: removes redundant function n.pettik 2019-03-15 15:45 ` [PATCH 06/13] sql: aux functions to support big integers Stanislav Zudin 2019-03-25 15:13 ` [tarantool-patches] " n.pettik 2019-03-15 15:45 ` [PATCH 07/13] sql: arithmetic functions " Stanislav Zudin 2019-03-25 15:13 ` [tarantool-patches] " n.pettik 2019-04-01 20:43 ` Stanislav Zudin 2019-04-02 7:54 ` Konstantin Osipov 2019-04-02 7:52 ` Konstantin Osipov 2019-03-15 15:45 ` [PATCH 08/13] sql: aggregate sql functions support big int Stanislav Zudin 2019-03-25 15:13 ` [tarantool-patches] " n.pettik 2019-04-01 20:43 ` Stanislav Zudin 2019-04-02 7:57 ` [tarantool-patches] " Konstantin Osipov 2019-03-15 15:45 ` [PATCH 09/13] sql: fixes errors Stanislav Zudin 2019-03-25 15:14 ` [tarantool-patches] " n.pettik 2019-03-15 15:45 ` [PATCH 10/13] sql: fixes an error in sqlSubInt64 Stanislav Zudin 2019-03-25 15:14 ` [tarantool-patches] " n.pettik 2019-03-15 15:45 ` [PATCH 11/13] sql: fixes an error in string to int64 conversion Stanislav Zudin 2019-03-25 15:14 ` [tarantool-patches] " n.pettik 2019-03-15 15:45 ` [PATCH 12/13] sql: fixes an error in uint64 to double casting Stanislav Zudin 2019-03-25 15:15 ` [tarantool-patches] " n.pettik 2019-03-15 15:45 ` [PATCH 13/13] sql: support -2^63 .. 2^64-1 integer type Stanislav Zudin 2019-03-25 15:25 ` [tarantool-patches] " n.pettik 2019-04-01 20:44 ` Stanislav Zudin 2019-03-25 15:10 ` [tarantool-patches] Re: [PATCH 00/13] " n.pettik 2019-04-01 20:38 ` Stanislav Zudin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5080d8b28aed2d2ae14bcf709ddcf65d43be797b.1552663061.git.szudin@tarantool.org \ --to=szudin@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [PATCH 05/13] sql: removes redundant function.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox