From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Oleg Babin <olegrok@tarantool.org>, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH vshard 1/1] router: bucket_id_strcrc32 and bucket_id_mpcrc32
Date: Mon, 2 Mar 2020 22:06:49 +0100 [thread overview]
Message-ID: <5033adad-c28d-02e3-6de7-8e22a35c7f5c@tarantool.org> (raw)
In-Reply-To: <ddd8aa66-b376-034c-fa0b-d4db26e6be61@tarantool.org>
Thanks for the review!
On 02/03/2020 09:10, Oleg Babin wrote:
> Hi! Your tests fail on Tarantool 1.10:
>
> [001] Test failed! Result content mismatch:
> [001] --- unit/router.result Mon Mar 2 10:54:48 2020
> [001] +++ unit/router.reject Mon Mar 2 11:02:21 2020
> [001] @@ -75,7 +75,7 @@
> [001] | - - string
> [001] | - '1'
> [001] | - 477
> [001] - | - - ctype<struct 106>
> [001] + | - - number
> [001] | - 1
> [001] | - 477
> [001] | ...
>
>
> Without taking this into account - patch LGTM.
I fixed that and pushed to master.
next prev parent reply other threads:[~2020-03-02 21:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 23:52 Vladislav Shpilevoy
2020-02-26 7:15 ` Oleg Babin
2020-02-27 0:22 ` Vladislav Shpilevoy
2020-02-27 10:12 ` Oleg Babin
2020-02-29 17:09 ` Vladislav Shpilevoy
2020-03-02 8:10 ` Oleg Babin
2020-03-02 21:06 ` Vladislav Shpilevoy [this message]
2020-02-26 8:20 ` Konstantin Osipov
2020-02-27 0:25 ` Vladislav Shpilevoy
2020-02-27 6:53 ` Konstantin Osipov
2020-02-29 17:10 ` Vladislav Shpilevoy
2020-03-01 16:52 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5033adad-c28d-02e3-6de7-8e22a35c7f5c@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=olegrok@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH vshard 1/1] router: bucket_id_strcrc32 and bucket_id_mpcrc32' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox