Tarantool development patches archive
 help / color / mirror / Atom feed
From: Leonid Vasiliev <lvasiliev@tarantool.org>
To: alexander.turenko@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH] Release all taken tasks on start
Date: Wed, 18 Dec 2019 11:52:56 +0300	[thread overview]
Message-ID: <4fdff09679c5a82c5f845343895b9d54be39b653.1576658855.git.lvasiliev@tarantool.org> (raw)

https://github.com/tarantool/queue/issues/66
https://github.com/tarantool/queue/tree/lvasiliev/gh-66-release-taken-tasks-after-reboot

If some tasks have been taken and don't released before shutdown
of the tarantool instance (for example: tarantool instance has been killed)
such task go to 'hung' state (noone can take the task now).
So, we must release all taken tasks on start of the queue module.

---
 queue/abstract.lua | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/queue/abstract.lua b/queue/abstract.lua
index ad8817d..ed07d85 100644
--- a/queue/abstract.lua
+++ b/queue/abstract.lua
@@ -511,7 +511,18 @@ function method.start()
         })
     end
 
-    _queue:pairs():each(recreate_tube)
+    for _, tube_tuple in _queue:pairs() do
+        local space_name = tube_tuple[3]
+        tube = recreate_tube(tube_tuple)
+        local space = box.space[space_name]
+        for _, task_tuple in space:pairs() do
+            -- Release all taken tasks
+            local tid, task_state = task_tuple:unpack()
+            if task_state == state.TAKEN then
+                tube.raw:release(tid, {})
+            end
+        end
+    end
 
     session.on_disconnect(queue._on_consumer_disconnect)
     return queue
-- 
2.17.1

             reply	other threads:[~2019-12-18  8:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18  8:52 Leonid Vasiliev [this message]
2020-01-27 12:27 ` Leonid Vasiliev
2020-02-26 12:19   ` Alexander Turenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fdff09679c5a82c5f845343895b9d54be39b653.1576658855.git.lvasiliev@tarantool.org \
    --to=lvasiliev@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] Release all taken tasks on start' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox