From: Leonid Vasiliev <lvasiliev@tarantool.org>
To: Artem Starshov <artemreyt@tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] luacheck: fixed warning in tarantoolctl.in
Date: Wed, 14 Oct 2020 16:11:14 +0300 [thread overview]
Message-ID: <4efb7591-5d3e-d084-7899-f823416e1392@tarantool.org> (raw)
In-Reply-To: <2a19304adfd3877d0fa26cde1d8d8c313a291588.1602677553.git.artemreyt@tarantool.org>
LGTM.
On 14.10.2020 15:14, Artem Starshov wrote:
> Changed passing global variable arg to function
> find_instance_name(arg) instead of passing arg[0] and arg[2] separately.
> And removed exception in .luacheckrc for file /extra/dist/tarantoolctl.in.
>
> This change only solves linter warning, nothing else.
> > Brach:
https://github.com/tarantool/tarantool/tree/artemreyt/gh-4929-luacheck-warning-tarantoolctl
> Issue: https://github.com/tarantool/tarantool/issues/4929
Branch and Issue are not a part of the commit message, add it after
"---". (Don't resend this patch. This comment is for future patches)
>
> Fixed #4929.
> ---
next prev parent reply other threads:[~2020-10-14 13:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 12:14 Artem Starshov
2020-10-14 13:11 ` Leonid Vasiliev [this message]
2020-10-14 23:04 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4efb7591-5d3e-d084-7899-f823416e1392@tarantool.org \
--to=lvasiliev@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=artemreyt@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] luacheck: fixed warning in tarantoolctl.in' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox