Tarantool development patches archive
 help / color / mirror / Atom feed
* [tarantool-patches] [PATCH 1/1] test: fix swim test on a bit cluster failure detection
@ 2019-04-04 16:47 Vladislav Shpilevoy
  2019-04-04 16:47 ` [tarantool-patches] " Vladislav Shpilevoy
  0 siblings, 1 reply; 2+ messages in thread
From: Vladislav Shpilevoy @ 2019-04-04 16:47 UTC (permalink / raw)
  To: tarantool-patches

It takes random time since SWIM uses random members selection
for each round step. Appeared, that in one of tests choosen time
was too small sometimes. Now it is fixed by just increasing
timeout, but one of forthcoming patches reworks that test in
order to make it faster.

Follow up for f510dc6f46a96d1ff9898519fd1c73167b38d655
---
No branch - already pushed.
No issue.

 test/unit/swim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/unit/swim.c b/test/unit/swim.c
index 32d223a7a..860d3211e 100644
--- a/test/unit/swim.c
+++ b/test/unit/swim.c
@@ -389,7 +389,7 @@ swim_test_too_big_packet(void)
 	 * Dissemination of a detected failure takes long time
 	 * without help of the component, intended for that.
 	 */
-	double timeout = size * 3;
+	double timeout = size * 10;
 	int i = 0;
 	for (; i < size; ++i) {
 		double start = swim_time();
-- 
2.17.2 (Apple Git-113)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tarantool-patches] Re: [PATCH 1/1] test: fix swim test on a bit cluster failure detection
  2019-04-04 16:47 [tarantool-patches] [PATCH 1/1] test: fix swim test on a bit cluster failure detection Vladislav Shpilevoy
@ 2019-04-04 16:47 ` Vladislav Shpilevoy
  0 siblings, 0 replies; 2+ messages in thread
From: Vladislav Shpilevoy @ 2019-04-04 16:47 UTC (permalink / raw)
  To: tarantool-patches

Trivial, pushed to master.

On 04/04/2019 19:47, Vladislav Shpilevoy wrote:
> It takes random time since SWIM uses random members selection
> for each round step. Appeared, that in one of tests choosen time
> was too small sometimes. Now it is fixed by just increasing
> timeout, but one of forthcoming patches reworks that test in
> order to make it faster.
> 
> Follow up for f510dc6f46a96d1ff9898519fd1c73167b38d655
> ---
> No branch - already pushed.
> No issue.
> 
>  test/unit/swim.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/unit/swim.c b/test/unit/swim.c
> index 32d223a7a..860d3211e 100644
> --- a/test/unit/swim.c
> +++ b/test/unit/swim.c
> @@ -389,7 +389,7 @@ swim_test_too_big_packet(void)
>  	 * Dissemination of a detected failure takes long time
>  	 * without help of the component, intended for that.
>  	 */
> -	double timeout = size * 3;
> +	double timeout = size * 10;
>  	int i = 0;
>  	for (; i < size; ++i) {
>  		double start = swim_time();
> -- 
> 2.17.2 (Apple Git-113)
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-04 16:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04 16:47 [tarantool-patches] [PATCH 1/1] test: fix swim test on a bit cluster failure detection Vladislav Shpilevoy
2019-04-04 16:47 ` [tarantool-patches] " Vladislav Shpilevoy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox