From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Mergen Imeev <imeevma@tarantool.org>,
Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: remove implicit cast for COMPARISON
Date: Fri, 3 Apr 2020 01:47:41 +0200 [thread overview]
Message-ID: <4d11ccea-2520-787b-de42-e2fdcaa4fec4@tarantool.org> (raw)
In-Reply-To: <20200330165313.GA14800@tarantool.org>
>>>> diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h
>>>> index 1579cc9..cd626bd 100644
>>>> --- a/src/box/sql/sqlInt.h
>>>> +++ b/src/box/sql/sqlInt.h
>>>> @@ -1304,6 +1304,9 @@ enum trim_side_mask {
>>>> (X) == FIELD_TYPE_UNSIGNED || \
>>>> (X) == FIELD_TYPE_DOUBLE)
>>>>
>>>> +#define sql_mp_type_is_numeric(X) ((X) == MP_INT || (X) == MP_UINT || \
>>>> + (X) == MP_FLOAT || (X) == MP_DOUBLE)
>>>
>>>
>>> 7. Is there a ticket to stop conveting MEM_* to MP_*?
>>
>> Hm, I thought I created once such ticket, but in fact failed to
>> find it. If you are OK with suggestion below concerning splitting
>> mem type into two members, I'll open an issue.
>>
> Does anyony mind if I do all this here, before main patch-set?
I am ok with that. But you need to do it quick then, because
the release is close.
next prev parent reply other threads:[~2020-04-02 23:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 12:34 imeevma
2020-03-29 22:29 ` Vladislav Shpilevoy
2020-03-30 11:38 ` Nikita Pettik
2020-03-30 16:53 ` Mergen Imeev
2020-04-02 23:47 ` Vladislav Shpilevoy [this message]
2020-04-21 12:42 ` Mergen Imeev
2020-04-26 18:22 ` Vladislav Shpilevoy
-- strict thread matches above, loose matches on Subject: below --
2020-02-20 8:00 imeevma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d11ccea-2520-787b-de42-e2fdcaa4fec4@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 1/1] sql: remove implicit cast for COMPARISON' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox