Re: [tarantool-patches] Re: [PATCH v3 7/7] memtx: introduce tuple compare hint

[Kirill Shcherbatov <kshcherbatov@tarantool.org>]

> See a few minor comments inline. Apart from them the patch is fine by
> me, but as Kostja justifiably noted, may be it's worth enabling hints
> for all data types, including floating point numbers. Then we wouldn't
> need the memtx tree parametrization introduced by the previous patches.
> OTOH we will probably need it anyway for multikey indexes.
We really need memtx tree parametrization at least because multikey index
tree has own MEMTX_TREE_COMPARE/MEMTX_TREE_COMPARE_KEY functions
(that use multikey_idx).
Show kshch/gh-1257-multikey-index branch for more details.

>> +template<bool is_nullable>
>> +static uint64_t
>> +key_hint_uint(const char *key, struct key_def *key_def)
>> +{
>> +	(void)key_def;
>> +	assert(key_part_is_nullable(key_def->parts) == is_nullable);
>> +	assert(key_def->parts->type == FIELD_TYPE_UNSIGNED ||
>> +	       key_def->parts->type == FIELD_TYPE_INTEGER);
> 
> FIELD_TYPE_INTEGER? How can that be?
I've reused it below. But ok, let's just inline it.

> Should be buf[8]?
Yep.