Re: [Tarantool-patches] [PATCH v8 12/14] test: fix luacheck warnings W612, W613, W614 in test/sql-tap

[Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Thanks for the patch!

See 3 comments below.

On 21.01.2021 13:50, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> W612 (A line contains trailing whitespace)
> W613 (Trailing whitespace in a string)
> W614 (Trailing whitespace in a comment)
> 
> Note: changes were made automatically in vim with regexp "%s/\s\+$//e".
> 
> Part of #5464
> ---
> diff --git a/test/sql-tap/analyzeD.test.lua b/test/sql-tap/analyzeD.test.lua
> index 12722a3d4..e0426b974 100755
> --- a/test/sql-tap/analyzeD.test.lua
> +++ b/test/sql-tap/analyzeD.test.lua
> @@ -54,7 +54,7 @@ test:do_test(
>  			ANALYZE;
>  		]])
>  	end, {
> -        	-- <1.1> 
> +        	-- <1.1>

1. Git highligts this line with red. I assume here is an inconsistency
between tabs and spaces. But it does not matter as these comments can
be dropped. They are useless artifacts of TCL -> Lua translation.

>          	-- </1.1>
>      })
> diff --git a/test/sql-tap/join.test.lua b/test/sql-tap/join.test.lua
> index 1fc968307..4175608fd 100755
> --- a/test/sql-tap/join.test.lua
> +++ b/test/sql-tap/join.test.lua
> @@ -564,6 +564,7 @@ test:do_catchsql_test(
>          -- </join-3.4.2>
>      })
>  
> +-- luacheck: ignore

2. Why? You couldn't delete some whitespaces here?
Or what is the issue?

>  test:do_catchsql_test(
>      "join-3.5",
>      [[
> diff --git a/test/sql-tap/tkt3935.test.lua b/test/sql-tap/tkt3935.test.lua
> index 7138e9e6a..f3bbe0b9f 100755
> --- a/test/sql-tap/tkt3935.test.lua
> +++ b/test/sql-tap/tkt3935.test.lua
> @@ -27,30 +27,31 @@ test:do_execsql_test(
>          CREATE TABLE t2(c INT primary key, d INT);
>      ]], {
>          -- <tkt3935.1>
> -        
> +
>          -- </tkt3935.1>
>      })
>  
>  test:do_execsql_test(
>      "tkt3935.2",
>      [[
> -        SELECT j1.b FROM ( SELECT * FROM t1 INNER JOIN t2 ON a=c ) AS j1 
> +        SELECT j1.b FROM ( SELECT * FROM t1 INNER JOIN t2 ON a=c ) AS j1
>      ]], {
>          -- <tkt3935.2>
> -        
> +
>          -- </tkt3935.2>
>      })
>  
>  test:do_execsql_test(
>      "tkt3935.3",
>      [[
> -        SELECT j1.b FROM (t1 INNER JOIN t2 ON a=c) AS j1 
> +        SELECT j1.b FROM (t1 INNER JOIN t2 ON a=c) AS j1
>      ]], {
>          -- <tkt3935.3>
> -        
> +
>          -- </tkt3935.3>
>      })
>  
> +-- luacheck: ignore

3. The same question as in the previous comment.

>  test:do_catchsql_test(
>      "tkt3935.4",
>      [[