From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@dev.tarantool.org,
tarantool-patches@freelists.org,
Kirill Yukhin <kyukhin@tarantool.org>
Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH 1/1] replication: auto reconnect if password is invalid
Date: Fri, 18 Oct 2019 00:43:46 +0200 [thread overview]
Message-ID: <4c463b9f-8d99-b3eb-09cf-109d651494b5@tarantool.org> (raw)
In-Reply-To: <20191017222805.GA19660@atlas>
Kostja, thanks for the review!
Kirill, your turn.
On 18/10/2019 00:28, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/10/18 00:13]:
>> Before the patch there was a race in replication
>> password configuration. It was possible that a replica
>> connects to a master with a custom password before
>> that password is actually set. The replica treated the
>> error as critical and exited.
>>
>> But in fact it is not critical. Replica even can
>> withstand absence of a user and keeps reconnecting.
>> Wrong password situation arises from the same problem
>> of non atomic configuration and is fixed the same -
>> keep reconnect attempts if the password was wrong.
>>
>> Closes #4550
>
> lgtm
>
next prev parent reply other threads:[~2019-10-17 22:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 21:16 [Tarantool-patches] " Vladislav Shpilevoy
2019-10-17 22:28 ` Konstantin Osipov
2019-10-17 22:43 ` Vladislav Shpilevoy [this message]
2019-10-28 6:19 ` [Tarantool-patches] [tarantool-patches] " Kirill Yukhin
2019-11-14 11:20 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c463b9f-8d99-b3eb-09cf-109d651494b5@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH 1/1] replication: auto reconnect if password is invalid' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox