From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] net.box: fix invalid index:count() with iterator
Date: Wed, 18 Jul 2018 00:44:30 +0300 [thread overview]
Message-ID: <4c1c291d-04e8-023b-d85f-a7cf8a3741d8@tarantool.org> (raw)
In-Reply-To: <7f6ffe078125bd2cb0523f245160236cfb403606.1531827189.git.kshcherbatov@tarantool.org>
Thanks for the patch! LGTM.
On 17/07/2018 14:41, Kirill Shcherbatov wrote:
> Net.box didn't pass options containing iterator to
> server side.
> There were also invalid results for two :count tests in
> net.box.result file.
>
> Thanks @ademenev for contributing problem and help with
> problem locating.
>
> Closes #3262.
> ---
> Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3262-fix-netbox-index-count
> Issue: https://github.com/tarantool/tarantool/issues/3262
>
> src/box/lua/net_box.lua | 2 +-
> test/box/net.box.result | 34 ++++++++++++++++++++++++++++++++--
> test/box/net.box.test.lua | 23 +++++++++++++++++++++++
> 3 files changed, 56 insertions(+), 3 deletions(-)
>
next prev parent reply other threads:[~2018-07-17 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 11:41 [tarantool-patches] " Kirill Shcherbatov
2018-07-17 21:44 ` Vladislav Shpilevoy [this message]
2018-07-19 10:23 ` [tarantool-patches] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c1c291d-04e8-023b-d85f-a7cf8a3741d8@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] net.box: fix invalid index:count() with iterator' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox