Re: [Tarantool-patches] [PATCH v2 0/2] decNumber utilites for SQL

[Serge Petrenko <sergepetrenko@tarantool.org>]

24.06.2020 19:53, Chris Sosnin пишет:
> Changes in v2:
> - Instead of skipping whitespaces, allow FromString to parse
> valid beginning of the string and return pointer to the next
> character. Thus, we can check for whitespaces ourselves.
> This also requires lib/core changes: either pass a pointer
> to decimal_from_string and check for '\0' after every use, or
> refactor it so it works the same way and introduce something like strtodec.
> - Rename decIsWhole -> decIsInt.
>
> branch: https://github.com/tarantool/decNumber/tree/ksosnin/utilities-for-sql
> related issue: https://github.com/tarantool/tarantool/issues/4415


LGTM

>
> Chris Sosnin (2):
>    Refactor decNumberFromString
>    Add IsInt method for checking the fractional part of a number
>
>   decNumber.c | 46 ++++++++++++++++++++++++++++++++++++++--------
>   decNumber.h | 27 ++++++++++++++-------------
>   2 files changed, 52 insertions(+), 21 deletions(-)
>
-- 
Serge Petrenko