From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 0/2] sql: restrict nullable action definitions
Date: Fri, 13 Jul 2018 13:26:07 +0300 [thread overview]
Message-ID: <4b6e3dc7-13be-66a1-086a-ecb48f39a798@tarantool.org> (raw)
In-Reply-To: <cover.1531413184.git.kshcherbatov@tarantool.org>
Thanks for the patchset! See 1 comments below.
On 12/07/2018 19:34, Kirill Shcherbatov wrote:
> This patch dissallows define multiple "NULL", "NOT NULL"
Typo.
> options per column and fixes silent implicit behavior
> for invalid "NULL PRIMARY KEY" construction.
>
> Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3473-on-conflict-defaults-fixes
> Issue: https://github.com/tarantool/tarantool/issues/3473
>
> Kirill Shcherbatov (2):
> sql: restrict nullable action definitions
> sql: fixed possible leak in sqlite3EndTable
>
> src/box/alter.cc | 1 +
> src/box/field_def.c | 1 +
> src/box/field_def.h | 3 ++-
> src/box/sql/build.c | 53 +++++++++++++++++++++++++++++++++++++------
> src/box/sql/parse.y | 2 +-
> test/sql/on-conflict.result | 13 +++++++++++
> test/sql/on-conflict.test.lua | 6 +++++
> 7 files changed, 70 insertions(+), 9 deletions(-)
>
next prev parent reply other threads:[~2018-07-13 10:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 16:34 [tarantool-patches] " Kirill Shcherbatov
2018-07-12 16:34 ` [tarantool-patches] [PATCH v1 1/2] " Kirill Shcherbatov
2018-07-13 10:26 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-13 16:05 ` Kirill Shcherbatov
2018-07-13 20:03 ` Vladislav Shpilevoy
2018-07-16 9:43 ` Kirill Shcherbatov
2018-07-16 10:20 ` Vladislav Shpilevoy
2018-07-16 12:27 ` Kirill Shcherbatov
2018-07-12 16:34 ` [tarantool-patches] [PATCH v1 2/2] sql: fixed possible leak in sqlite3EndTable Kirill Shcherbatov
2018-07-13 10:26 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-13 16:05 ` Kirill Shcherbatov
2018-07-13 10:26 ` Vladislav Shpilevoy [this message]
2018-07-16 12:28 ` [tarantool-patches] [PATCH v1 2/4] sql: refactor sqlite3AddNotNull function Kirill Shcherbatov
2018-07-16 13:41 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-16 12:28 ` [tarantool-patches] [PATCH v1 4/4] sql: get rid of Column structure Kirill Shcherbatov
2018-07-16 13:40 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-16 16:33 ` Kirill Shcherbatov
2018-07-17 9:32 ` Vladislav Shpilevoy
2018-07-17 14:08 ` Kirill Shcherbatov
2018-07-17 22:01 ` Vladislav Shpilevoy
2018-07-18 7:25 ` Kirill Shcherbatov
2018-07-18 8:04 ` Vladislav Shpilevoy
2018-07-18 16:41 ` n.pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b6e3dc7-13be-66a1-086a-ecb48f39a798@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 0/2] sql: restrict nullable action definitions' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox