From: Evgeniy Temirgaleev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] ARM64: Don't fuse sign extensions into logical operands.
Date: Wed, 18 Nov 2026 12:42:54 +0300 [thread overview]
Message-ID: <4b6aa5c0-f807-48bd-9c03-5686b7a196c2@tarantool.org> (raw)
In-Reply-To: <av1iWTvgp9T1AUVN@root>
Hi, Sergey!
On 11/18/26 11:31 AM, Sergey Kaplun wrote:
> Hi, Evgeniy!
> Thanks for the review!
>
> On 17.11.26, Evgeniy Temirgaleev wrote:
>> Hi, Sergey! Thanks for the patch! LGTM with a note.
>>
>> On 11/16/26 3:05 PM, Sergey Kaplun wrote:
>>> From: Mike Pall <mike>
>>>
>>> Thanks to Peter Cawley.
>>>
>>> (cherry picked from commit 90742d91c27d185b70d1b4a6343fb6b7c26002db)
>>>
>>> Logical instructions [1] (`orr`, etc.) have no sign extension form
>>> (unlike `ADD Xd, Xn, Wm, SXTW #k`). This makes the fusing sign extension
>>> into them meaningless and leads to the incorrect result in the
>>> JIT-compiled code.
>>>
>>> This patch prevents the fusing of sign extension (`sxtw`) into logical
>>> instructions.
>>>
>>> [1]: https://cybersandeep.gitbook.io/arm64basicguide/chapter-3-basic-arm64-instructions#id-3.2.2-logical-instructions
>> The article contains only basic form of arithmetic and logical (and
>> other) instructions. It omits their complex forms with optional second
>> operand shift and/or extension and is not illustrative for this patch.
>
> Yes, I've failed to find the definition of the logical instructions at
> the non-blocked resources :(. At least it has the definition of logical
> instruction...
> Do you think it is better to remove the link to avoid the confusion?
>
I found a working link [1]. You can use it with the document reference
data: "Arm® Instruction Set. Version 1.0. Reference Guide" (version 25
October 2018), "Chapter D2. A64 General Instructions".
[1]
https://www.heenes.de/ro/material/arm/arm_instruction_set_reference_guide.pdf
>>
>>>
>>> Sergey Kaplun:
>>> * added the description and the test for the problem
>>>
>>> Part of tarantool/tarantool#13442
>>> ---
>
> <snipped>
>
>> --
>> Best regards,
>> Evgeniy Temirgaleev
>>
>
--
--
Best regards,
Evgeniy Temirgaleev
next prev parent reply other threads:[~2026-11-18 9:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 12:05 Sergey Kaplun via Tarantool-patches
2026-11-17 13:25 ` Evgeniy Temirgaleev via Tarantool-patches
2026-11-18 8:31 ` Sergey Kaplun via Tarantool-patches
2026-11-18 9:42 ` Evgeniy Temirgaleev via Tarantool-patches [this message]
2026-11-18 11:39 ` Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b6aa5c0-f807-48bd-9c03-5686b7a196c2@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=e.temirgaleev@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] ARM64: Don'\''t fuse sign extensions into logical operands.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox