From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 88C816F829; Wed, 18 Nov 2026 12:42:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 88C816F829 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1794994977; bh=kbeYTXz4AoRDj89QQi/caTEbokFBzC0GUyLNZkjw6MU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lFituLCDEI3yCbFPr6Q7BQ0NWCGzF+fVZ/hx6YFqeobQDXky81B175k8g0aHCUdO/ s0PV/8s+fOi0v0R03SfD0lAPYftINYL665tMoiQUYsHPhth18wrkZdbdWLtMX6hmvT IsHTVUY9WX1xiPIdGv0IxWrfEBrBhndXfjqeji5Q= Received: from send220.i.mail.ru (send220.i.mail.ru [95.163.59.59]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 87D616F829 for ; Wed, 18 Nov 2026 12:42:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 87D616F829 Received: by exim-smtp-5fd8d99545-zs2cv with esmtpa (envelope-from ) id 1xTcBr-00000000N61-0BA0; Wed, 18 Nov 2026 12:42:55 +0300 Message-ID: <4b6aa5c0-f807-48bd-9c03-5686b7a196c2@tarantool.org> Date: Wed, 18 Nov 2026 12:42:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun References: <20261116120533.2886125-1-skaplun@tarantool.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9749DDC91F62168F93153D52FBA18BB599117403A6E84CCF3182A05F5380850401BD4B166BB99E4E73DE06ABAFEAF67059C3B74ED7BFD9CB1ED292EEF0D057DC2CC29A3283896A6B0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75263010198C72082EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FE9EFE935CD7C6AE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2D36CD45A4A5E56A92E070BE324C7D3C45E2B14FBB44684E1F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C06030C3405640F6718941B15DA834481F9449624AB7ADAF37BA3038C0950A5D36D5E8D9A59859A8B6373C3576551F00B976E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C304C8BA14588C48243847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A575653F1C5AB335E45002B1117B3ED696219B51CCE6B5CE8C4869453249F34FA4823CB91A9FED034534781492E4B8EEADB73CFAAED92B6E13BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659B69BF95033B62EB24706F599CBC8255E83039C9D702C23509CC589A149A2712DE45DB9281381CD65B8341EE9D5BE9A0A656DEC4145544C5A477BD906197CE86B1EEA6A31D779B4ADC7CEAA0681F5848F4C41F94D744909CEEF9E35A692215F79327F81E6EEE0AEB67A0F9F91F029B6AF33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXOcIETfglQORZ0zpDET4Zrk3igikrdHlWOCxh33gCKfgm5/lFOSIJYM= X-Mailru-Sender: 015BA6FC0EFA223AFF5DE35D6D355F43F3B4731A52E76D1820C74B26AAFF93454FDAEA403CCFC590E42C4E39D2ED70218C34D365DA2E1307B60569B44082A3A3197AF8DA6C69D34BA7BD66BEAC8CCB0C4198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ARM64: Don't fuse sign extensions into logical operands. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Evgeniy Temirgaleev via Tarantool-patches Reply-To: Evgeniy Temirgaleev Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! On 11/18/26 11:31 AM, Sergey Kaplun wrote: > Hi, Evgeniy! > Thanks for the review! > > On 17.11.26, Evgeniy Temirgaleev wrote: >> Hi, Sergey! Thanks for the patch! LGTM with a note. >> >> On 11/16/26 3:05 PM, Sergey Kaplun wrote: >>> From: Mike Pall >>> >>> Thanks to Peter Cawley. >>> >>> (cherry picked from commit 90742d91c27d185b70d1b4a6343fb6b7c26002db) >>> >>> Logical instructions [1] (`orr`, etc.) have no sign extension form >>> (unlike `ADD Xd, Xn, Wm, SXTW #k`). This makes the fusing sign extension >>> into them meaningless and leads to the incorrect result in the >>> JIT-compiled code. >>> >>> This patch prevents the fusing of sign extension (`sxtw`) into logical >>> instructions. >>> >>> [1]: https://cybersandeep.gitbook.io/arm64basicguide/chapter-3-basic-arm64-instructions#id-3.2.2-logical-instructions >> The article contains only basic form of arithmetic and logical (and >> other) instructions. It omits their complex forms with optional second >> operand shift and/or extension and is not illustrative for this patch. > > Yes, I've failed to find the definition of the logical instructions at > the non-blocked resources :(. At least it has the definition of logical > instruction... > Do you think it is better to remove the link to avoid the confusion? > I found a working link [1]. You can use it with the document reference data: "ArmĀ® Instruction Set. Version 1.0. Reference Guide" (version 25 October 2018), "Chapter D2. A64 General Instructions". [1] https://www.heenes.de/ro/material/arm/arm_instruction_set_reference_guide.pdf >> >>> >>> Sergey Kaplun: >>> * added the description and the test for the problem >>> >>> Part of tarantool/tarantool#13442 >>> --- > > > >> -- >> Best regards, >> Evgeniy Temirgaleev >> > -- -- Best regards, Evgeniy Temirgaleev