Tarantool development patches archive
 help / color / mirror / Atom feed
* [Tarantool-patches] [PATCH luajit] cmake: fix warnings about minimum required version
@ 2024-03-21  8:33 Sergey Bronnikov via Tarantool-patches
  2024-03-21 10:13 ` Maxim Kokryashkin via Tarantool-patches
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Sergey Bronnikov via Tarantool-patches @ 2024-03-21  8:33 UTC (permalink / raw)
  To: tarantool-patches, Sergey Kaplun, Maxim Kokryashkin

From: Sergey Bronnikov <sergeyb@tarantool.org>

CMake produces annoying warnings:

CMake Deprecation Warning at src/CMakeLists.txt:7 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

We cannot bump a minimum required CMake version without
bumping it in a Tarantool build system. However, we can set
a max supported CMake version and suppress a warning.
CMake 3.27.7 is a version used by me for a long time for
building LuaJIT. This version is tested and seen no policy warnings
with a that version.
---
Branch: https://github.com/tarantool/luajit/tree/ligurio/fix-cmake-warnings
Doc: https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html

NOTE: another solution is using CMAKE_WARN_DEPRECATED,
but I don't like it. Let's discuss.

1. https://cmake.org/cmake/help/latest/variable/CMAKE_WARN_DEPRECATED.html

 CMakeLists.txt                                 | 2 +-
 etc/CMakeLists.txt                             | 2 +-
 src/CMakeLists.txt                             | 2 +-
 src/host/CMakeLists.txt                        | 2 +-
 test/CMakeLists.txt                            | 2 +-
 test/LuaJIT-tests/CMakeLists.txt               | 2 +-
 test/LuaJIT-tests/src/CMakeLists.txt           | 2 +-
 test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt      | 2 +-
 test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt | 2 +-
 test/lua-Harness-tests/CMakeLists.txt          | 2 +-
 test/tarantool-tests/CMakeLists.txt            | 2 +-
 tools/CMakeLists.txt                           | 2 +-
 12 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 7f5e2afb..9edff6f3 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -8,7 +8,7 @@
 # --- Initial setup ------------------------------------------------------------
 
 # See the rationale below (near LUAJIT_TEST_BINARY variable).
-cmake_minimum_required(VERSION 3.1 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR)
 project(LuaJIT C)
 
 # XXX: Originally CMake machinery is introduced to make LuaJIT
diff --git a/etc/CMakeLists.txt b/etc/CMakeLists.txt
index d54fa794..39f6df77 100644
--- a/etc/CMakeLists.txt
+++ b/etc/CMakeLists.txt
@@ -1,7 +1,7 @@
 # Building supplementary materials for LuaJIT.
 
 # See the rationale in the root CMakeLists.txt.
-cmake_minimum_required(VERSION 3.1 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR)
 
 set(LUAJIT_PC_PREFIX ${CMAKE_INSTALL_PREFIX})
 if(CMAKE_LIBRARY_ARCHITECTURE)
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 03338306..be11dde6 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -4,7 +4,7 @@
 # Copyright (C) 2015-2020 IPONWEB Ltd.
 
 # See the rationale in the root CMakeLists.txt.
-cmake_minimum_required(VERSION 3.1 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR)
 
 enable_language(ASM)
 
diff --git a/src/host/CMakeLists.txt b/src/host/CMakeLists.txt
index 1ce3e224..3ca158a5 100644
--- a/src/host/CMakeLists.txt
+++ b/src/host/CMakeLists.txt
@@ -1,7 +1,7 @@
 # Building the toolchain for LuaJIT VM preprocessing.
 
 # See the rationale in the root CMakeLists.txt.
-cmake_minimum_required(VERSION 3.1 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR)
 
 # FIXME: Both minilua and buildvm need to be build with the HOST_*
 # toolchain.
diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
index 3ad5d15f..8af043f7 100644
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@@ -1,7 +1,7 @@
 # Running various test suites against LuaJIT.
 
 # See the rationale in the root CMakeLists.txt.
-cmake_minimum_required(VERSION 3.1 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR)
 
 include(MakeLuaPath)
 
diff --git a/test/LuaJIT-tests/CMakeLists.txt b/test/LuaJIT-tests/CMakeLists.txt
index a0fb5440..a884070a 100644
--- a/test/LuaJIT-tests/CMakeLists.txt
+++ b/test/LuaJIT-tests/CMakeLists.txt
@@ -1,5 +1,5 @@
 # See the rationale in the root CMakeLists.txt
-cmake_minimum_required(VERSION 3.1 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR)
 
 add_subdirectory(src)
 
diff --git a/test/LuaJIT-tests/src/CMakeLists.txt b/test/LuaJIT-tests/src/CMakeLists.txt
index 2f90da86..704c7acf 100644
--- a/test/LuaJIT-tests/src/CMakeLists.txt
+++ b/test/LuaJIT-tests/src/CMakeLists.txt
@@ -1,5 +1,5 @@
 # See the rationale in the root CMakeLists.txt.
-cmake_minimum_required(VERSION 3.1 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR)
 
 # Use `lib` prefix for loading via FFI and `require()`.
 AddTestLib(libctest libctest.c)
diff --git a/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt b/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt
index 98277f9a..7820d39b 100644
--- a/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt
+++ b/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt
@@ -2,7 +2,7 @@
 # in scope of https://github.com/tarantool/tarantool/issues/5845.
 
 # See the rationale in the root CMakeLists.txt.
-cmake_minimum_required(VERSION 3.1 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR)
 
 # XXX: There are two ways to set up the proper environment
 # described in the suite's README:
diff --git a/test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt b/test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt
index b496cbab..d34151e1 100644
--- a/test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt
+++ b/test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt
@@ -2,7 +2,7 @@
 # in scope of https://github.com/tarantool/tarantool/issues/5845.
 
 # See the rationale in the root CMakeLists.txt.
-cmake_minimum_required(VERSION 3.1 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR)
 
 # Build additional C libraries for tests.
 AddTestLib(lib1 lib1.c)
diff --git a/test/lua-Harness-tests/CMakeLists.txt b/test/lua-Harness-tests/CMakeLists.txt
index f748a8fd..2b4bb0ab 100644
--- a/test/lua-Harness-tests/CMakeLists.txt
+++ b/test/lua-Harness-tests/CMakeLists.txt
@@ -2,7 +2,7 @@
 # in scope of https://github.com/tarantool/tarantool/issues/5844.
 
 # See the rationale in the root CMakeLists.txt
-cmake_minimum_required(VERSION 3.1 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR)
 
 find_program(PROVE prove)
 if(NOT PROVE)
diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt
index e6d12984..c505f196 100644
--- a/test/tarantool-tests/CMakeLists.txt
+++ b/test/tarantool-tests/CMakeLists.txt
@@ -2,7 +2,7 @@
 # scope of https://github.com/tarantool/tarantool/issues/4478.
 
 # See the rationale in the root CMakeLists.txt.
-cmake_minimum_required(VERSION 3.1 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR)
 
 find_program(PROVE prove)
 if(NOT PROVE)
diff --git a/tools/CMakeLists.txt b/tools/CMakeLists.txt
index 695c079a..09fe0230 100644
--- a/tools/CMakeLists.txt
+++ b/tools/CMakeLists.txt
@@ -4,7 +4,7 @@
 # Copyright (C) 2015-2020 IPONWEB Ltd.
 
 # See the rationale in the root CMakeLists.txt.
-cmake_minimum_required(VERSION 3.1 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR)
 
 set(LUAJIT_TOOLS_DEPS)
 
-- 
2.34.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-07-09  8:05 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-21  8:33 [Tarantool-patches] [PATCH luajit] cmake: fix warnings about minimum required version Sergey Bronnikov via Tarantool-patches
2024-03-21 10:13 ` Maxim Kokryashkin via Tarantool-patches
2024-03-22 15:23   ` Sergey Bronnikov via Tarantool-patches
2024-04-08  9:15     ` Maxim Kokryashkin via Tarantool-patches
2024-06-17 12:47 ` Sergey Kaplun via Tarantool-patches
2024-06-18 10:23   ` Sergey Bronnikov via Tarantool-patches
2024-07-09  8:05 ` Sergey Kaplun via Tarantool-patches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox