[tarantool-patches] Re: [PATCH 2/2] sql: transactional DDL

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

On 20/07/2019 09:42, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/07/20 01:52]:
>> index 000000000..8f7f91151
>> --- /dev/null
>> +++ b/test/sql/ddl.result
>> @@ -0,0 +1,356 @@
>> +-- test-run result file version 2
>> +test_run = require('test_run').new()
>> + | ---
>> + | ...
>> +engine = test_run:get_cfg('engine')
>> + | ---
> 
> Just curious why did you choose  Lua test format and not SQL?
> 
> Now that SQL format is in place my personal preference would be is
> that it is used for SQL tests whenever possible, to improve
> readability (SQL syntax highlighting, autocompletion).
> 
> What do you miss in SQL tests format?
> 
> I personally only miss anonymous sql/psm blocks and loops.
> 
> 

Firstly, Lua tests still are easier to copy paste into console
as is. Secondly, I just used to write Lua tests. Thirdly, I
don't like tap tests, because you need compare results
manually instead of just printing them.