From: "Alexander V. Tikhonov" <avtikhon@tarantool.org> To: Kirill Yukhin <kyukhin@tarantool.org>, Serge Petrenko <sergepetrenko@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v1] test: flaky replication/gh-4928-tx-boundaries test Date: Sat, 5 Sep 2020 22:56:46 +0300 [thread overview] Message-ID: <48d336a709872d28d44dd1d2f2f489cf5df22404.1599335715.git.avtikhon@tarantool.org> (raw) On heavy loaded hosts found the following issue: [089] --- replication/gh-4928-tx-boundaries.result Wed Jul 29 04:08:29 2020 [089] +++ replication/gh-4928-tx-boundaries.reject Wed Jul 29 04:24:02 2020 [089] @@ -94,7 +94,7 @@ [089] | ... [089] box.info.replication[1].upstream.status [089] | --- [089] - | - follow [089] + | - disconnected [089] | ... [089] [089] box.space.glob:select{} It happend because replication upstream status check happend to early, when it was in only in 'disconnected' state. To give the replication status check routine ability to reach the needed 'follow' state it need to wait for it using test_run:wait_upstream() routine. Closes #5234 --- Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5234-fix-4928 Issue: https://github.com/tarantool/tarantool/issues/5234 test/replication/gh-4928-tx-boundaries.result | 4 ++-- test/replication/gh-4928-tx-boundaries.test.lua | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/replication/gh-4928-tx-boundaries.result b/test/replication/gh-4928-tx-boundaries.result index 969bd8438..4bd1b4b25 100644 --- a/test/replication/gh-4928-tx-boundaries.result +++ b/test/replication/gh-4928-tx-boundaries.result @@ -92,9 +92,9 @@ box.info.status | --- | - running | ... -box.info.replication[1].upstream.status +test_run:wait_upstream(1, {status = 'follow'}) | --- - | - follow + | - true | ... box.space.glob:select{} diff --git a/test/replication/gh-4928-tx-boundaries.test.lua b/test/replication/gh-4928-tx-boundaries.test.lua index 92526fc51..f245bff74 100644 --- a/test/replication/gh-4928-tx-boundaries.test.lua +++ b/test/replication/gh-4928-tx-boundaries.test.lua @@ -47,7 +47,7 @@ test_run:wait_vclock("replica", vclock) test_run:cmd('switch replica') box.info.status -box.info.replication[1].upstream.status +test_run:wait_upstream(1, {status = 'follow'}) box.space.glob:select{} -- 2.17.1
next reply other threads:[~2020-09-05 19:56 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-05 19:56 Alexander V. Tikhonov [this message] 2020-09-09 15:33 ` Serge Petrenko 2020-09-06 15:36 [Tarantool-patches] [PATCH v1] test: flaky replication/gh-4402-info-errno.test.lua Alexander V. Tikhonov 2020-09-06 15:36 ` [Tarantool-patches] [PATCH v1] test: flaky replication/gh-4928-tx-boundaries test Alexander V. Tikhonov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=48d336a709872d28d44dd1d2f2f489cf5df22404.1599335715.git.avtikhon@tarantool.org \ --to=avtikhon@tarantool.org \ --cc=kyukhin@tarantool.org \ --cc=sergepetrenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1] test: flaky replication/gh-4928-tx-boundaries test' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox