From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: kirichenkoga@gmail.com, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v4 0/4] replication: fix applying of rows originating from local instance
Date: Fri, 28 Feb 2020 00:24:01 +0100 [thread overview]
Message-ID: <48cf0b8a-0edc-6ebf-4a4e-87bb41411070@tarantool.org> (raw)
In-Reply-To: <1582838647.925618742@f148.i.mail.ru>
On 27/02/2020 22:24, Serge Petrenko wrote:
>
>
> Четверг, 27 февраля 2020, 2:54 +03:00 от Vladislav Shpilevoy <v.shpilevoy@tarantool.org>:
>
> Hi! Thanks for the patch!
>
> Please, add a @ChangeLog record.
>
> Hi!
> What kind of a changelog should I write?
> This is a bug fix with no visible behaviour change (speaking from the users point of view)
We add change log record for everything. For bugs too. It
should shortly describe what a bug was fixed. See examples in
https://github.com/tarantool/tarantool/releases
prev parent reply other threads:[~2020-02-27 23:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 10:00 sergepetrenko
2020-02-26 10:00 ` [Tarantool-patches] [PATCH v4 1/4] box: expose box_is_orphan method sergepetrenko
2020-02-26 10:00 ` [Tarantool-patches] [PATCH v4 2/4] wal: warn when trying to write a record with a broken lsn sergepetrenko
2020-02-26 10:00 ` [Tarantool-patches] [PATCH v4 3/4] replication: implement an instance id filter for relay sergepetrenko
2020-02-26 10:18 ` Konstantin Osipov
2020-02-26 11:16 ` Serge Petrenko
2020-02-26 23:54 ` Vladislav Shpilevoy
2020-02-27 6:48 ` Konstantin Osipov
2020-02-27 13:15 ` Serge Petrenko
2020-02-27 23:33 ` Vladislav Shpilevoy
2020-02-26 10:00 ` [Tarantool-patches] [PATCH v4 4/4] replication: do not relay rows coming from a remote instance back to it sergepetrenko
2020-02-26 10:23 ` Konstantin Osipov
2020-02-26 11:21 ` Serge Petrenko
2020-02-26 11:58 ` Konstantin Osipov
2020-02-26 15:58 ` Serge Petrenko
2020-02-26 16:40 ` Konstantin Osipov
2020-02-26 23:54 ` Vladislav Shpilevoy
2020-02-27 6:52 ` Konstantin Osipov
2020-02-27 14:13 ` Serge Petrenko
2020-02-27 21:17 ` Serge Petrenko
2020-02-27 23:22 ` Vladislav Shpilevoy
2020-02-28 8:03 ` Serge Petrenko
2020-02-26 23:54 ` [Tarantool-patches] [PATCH v4 0/4] replication: fix applying of rows originating from local instance Vladislav Shpilevoy
2020-02-27 21:24 ` Serge Petrenko
2020-02-27 23:24 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48cf0b8a-0edc-6ebf-4a4e-87bb41411070@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kirichenkoga@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4 0/4] replication: fix applying of rows originating from local instance' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox