From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: show formated MsgPack BLOB on select
Date: Tue, 3 Jul 2018 17:02:46 +0300 [thread overview]
Message-ID: <489910bc-cb18-b014-d034-7004b9135b44@tarantool.org> (raw)
In-Reply-To: <397d7f5b-3a1e-18e8-128e-cc006c3ae5cb@tarantool.org>
> Hello. Thanks for the patch! I have pushed my fixes on the
> branch in a separate commit. Please, look and squash if you
> are ok with it.
Tnx. Ok for me, excluding this:
+++ b/src/box/sql/vdbeapi.c
@@ -224,8 +224,7 @@ sqlite3_value_int64(sqlite3_value * pVal)
enum sql_subtype
sqlite3_value_subtype(sqlite3_value * pVal)
{
- Mem *pMem = (Mem *) pVal;
- return (pMem->flags & MEM_Subtype) != 0 ? pMem->subtype : 0;
+ return (pVal->flags & MEM_Subtype) != 0 ? pVal->subtype : SQL_SUBTYPE_NO;
}
on head "review review fixes"
> Nikita, please, look at my changes too, they are not minor.
next prev parent reply other threads:[~2018-07-03 14:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 12:33 [tarantool-patches] " Kirill Shcherbatov
2018-07-02 13:36 ` [tarantool-patches] " n.pettik
2018-07-02 14:23 ` Kirill Shcherbatov
2018-07-02 14:55 ` n.pettik
2018-07-03 12:48 ` Kirill Shcherbatov
2018-07-03 13:29 ` Vladislav Shpilevoy
2018-07-03 14:02 ` Kirill Shcherbatov [this message]
2018-07-04 0:13 ` n.pettik
2018-07-04 6:48 ` Kirill Shcherbatov
2018-07-04 10:44 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489910bc-cb18-b014-d034-7004b9135b44@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: show formated MsgPack BLOB on select' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox