From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [tarantool-patches] [PATCH v1 1/1] tests: simplify test box/access_mist.test.lua
Date: Sat, 19 Oct 2019 15:53:38 +0200 [thread overview]
Message-ID: <488e0dd6-d503-8713-2028-3253d77f95e3@tarantool.org> (raw)
In-Reply-To: <4fafd7563cd835c8679b41f99815e734f3113878.1571480828.git.imeevma@gmail.com>
Hi! Thanks for the patch!
That is better, now the test is not such fragile.
But its result file is still huge.
I checked history of these three lines:
box.space._user:select()
box.space._space:select()
box.space._func:select()
And appeared, that they are 5 years old. Their initial
purpose was lost long time ago. I think, it is better
to just drop them.
next prev parent reply other threads:[~2019-10-19 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 10:30 [Tarantool-patches] " imeevma
2019-10-19 13:53 ` Vladislav Shpilevoy [this message]
2019-10-24 10:29 ` [Tarantool-patches] [tarantool-patches] " Mergen Imeev
2019-10-24 19:54 ` [Tarantool-patches] [tarantool-patches] " Vladislav Shpilevoy
2019-10-28 6:37 ` [Tarantool-patches] [tarantool-patches] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488e0dd6-d503-8713-2028-3253d77f95e3@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [Tarantool-patches] [tarantool-patches] [PATCH v1 1/1] tests: simplify test box/access_mist.test.lua' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox