From: Imeev Mergen <imeevma@tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@freelists.org Subject: [tarantool-patches] Re: [PATCH v8 0/6] sql: remove box.sql.execute Date: Thu, 24 Jan 2019 10:31:00 +0300 [thread overview] Message-ID: <48496502-a8a1-2409-3dd4-d336bfddab76@tarantool.org> (raw) In-Reply-To: <ace60d17-b407-9ca3-da9a-67ec0bda5139@tarantool.org> Hi! Thanks for comments. Also, I sent wrong branch to review, sorry about that. Right branch is: https://github.com/tarantool/tarantool/tree/imeevma/gh-3505-replace-box_sql_execute-by-box_execute On 1/22/19 10:58 PM, Vladislav Shpilevoy wrote: > Hi! Thanks for the fixes! > > On 19/01/2019 16:20, imeevma@tarantool.org wrote: >> The goal of this patch-set is to make functions from execute.c >> the only way to execute SQL statements. This goal includes >> similar output for executed SQL statements no matter how they >> were executed: through net.box or through box. >> >> This is the eighth version of patch-set. It is not complete. It >> still has no last part, which is replacing box.sql.execute by >> box.execute, because it will lead to massive test editing. > > It was not necessary to resend the whole patchset just for such > minor comments. Strictly speaking, it was not necessary for some > other older versions. Ok, understood. > >> >> For now this patch-set blocked by #3832. Small temporary fix added >> to temporary patch of patch-set. >> >> https://github.com/tarantool/tarantool/issues/3505 >> https://github.com/tarantool/tarantool/tree/imeevma/gh-3505-no-sql-execute >> >> >> General information of difference from previous version of >> patch-set: > > If we nonetheless consider this mail thread as a new patchset, > the text below does not describe the difference correctly. It is > an old description. > > Besides, in each cover-letter of each version you should list > differences between each pair of sequential versions, as I know. > Ok, understood. >> - Added new commit that removes lua_error() from luaL_tofield(). >> - Added new and fixed old comments and descriptions. >> - Fixed some bugs. >> - Refactoring. >> >> A bit about patches of the patch-set: >> >> Patch 1 removes lua_error() from luaL_tofield(). >> >> Patch 2 moves map creation from xrow functions to >> sql_response_dump(). It allows us to use sql_response_dump() as >> method of port. >> >> Patch 3 creates port_sql and two its methods: dump_msgpack() and >> destroy(). >> >> Patch 4 creates dump_lua() method for port_sql. >> >> Patch 5 adds binding to new_execute(). >> >> Patch 6 is temporary patch. It was created to check that >> new_execute() is able to pass through tests created for execute(). >> >> v1: >> https://www.freelists.org/post/tarantool-patches/PATCH-v1-0010-sql-remove-boxsqlexecute >> >> v2: >> https://www.freelists.org/post/tarantool-patches/PATCH-v2-07-Remove-boxsqlexecute >> >> v3: >> https://www.freelists.org/post/tarantool-patches/PATCH-v3-07-Remove-boxsqlexecute >> >> v4: >> https://www.freelists.org/post/tarantool-patches/PATCH-v4-05-Remove-boxsqlexecute >> >> v5: >> https://www.freelists.org/post/tarantool-patches/PATCH-v5-05-sql-remove-boxsqlexecute >> >> v6: >> https://www.freelists.org/post/tarantool-patches/PATCH-v6-05-sql-remove-boxsqlexecute >> >> v7: >> https://www.freelists.org/post/tarantool-patches/PATCH-v7-06-sql-remove-boxsqlexecute >> >> >> Mergen Imeev (6): >> lua: remove exceptions from function luaL_tofield() >> iproto: move map creation to sql_response_dump() >> iproto: create port_sql >> lua: create method dump_lua for port_sql >> lua: parameter binding for new execute() >> sql: check new box.sql.execute() >> >> src/box/execute.c | 507 >> +++++++++++++++++++++++++++++++++++++++++-------- >> src/box/execute.h | 63 ++---- >> src/box/iproto.cc | 18 +- >> src/box/lua/call.c | 9 +- >> src/box/lua/schema.lua | 23 +++ >> src/box/lua/sql.c | 37 +++- >> src/box/lua/tuple.c | 3 +- >> src/box/port.h | 1 - >> src/box/xrow.c | 8 +- >> src/box/xrow.h | 9 +- >> src/lua/msgpack.c | 12 +- >> src/lua/utils.c | 97 +++++----- >> src/lua/utils.h | 8 +- >> 13 files changed, 589 insertions(+), 206 deletions(-) >>
prev parent reply other threads:[~2019-01-24 7:31 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-19 13:20 [tarantool-patches] " imeevma 2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 1/6] lua: remove exceptions from function luaL_tofield() imeevma 2019-01-22 19:58 ` [tarantool-patches] " Vladislav Shpilevoy 2019-01-24 7:27 ` Imeev Mergen 2019-01-29 20:42 ` Vladislav Shpilevoy 2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 2/6] iproto: move map creation to sql_response_dump() imeevma 2019-01-25 16:07 ` [tarantool-patches] " Konstantin Osipov 2019-01-29 20:42 ` Vladislav Shpilevoy 2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 3/6] iproto: create port_sql imeevma 2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 4/6] lua: create method dump_lua for port_sql imeevma 2019-01-29 20:42 ` [tarantool-patches] " Vladislav Shpilevoy 2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 5/6] lua: parameter binding for new execute() imeevma 2019-01-19 13:20 ` [tarantool-patches] [PATCH v8 6/6] sql: check new box.sql.execute() imeevma 2019-01-22 19:58 ` [tarantool-patches] Re: [PATCH v8 0/6] sql: remove box.sql.execute Vladislav Shpilevoy 2019-01-24 7:31 ` Imeev Mergen [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=48496502-a8a1-2409-3dd4-d336bfddab76@tarantool.org \ --to=imeevma@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=v.shpilevoy@tarantool.org \ --subject='[tarantool-patches] Re: [PATCH v8 0/6] sql: remove box.sql.execute' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox