From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>, Sergey Bronnikov <estetus@gmail.com>
Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit][v2] LJ_GC64: Fix lua_concat().
Date: Tue, 31 Oct 2023 21:14:09 +0300 [thread overview]
Message-ID: <4833d8b4-7b0d-4955-94d7-c8a2b53b9996@tarantool.org> (raw)
In-Reply-To: <ZUEkhSdVPtwo4F9D@tarantool.org>
Hello, Igor
On 10/31/23 19:00, Igor Munkin via Tarantool-patches wrote:
> Sergey,
>
> I didn't find the patch where <assert_str_equal>/<assert_str_not_equal>
> are introduced. Furthermore, I'd rather recommend to introduce
> <assert_str0_equal>/<assert_str0_not_equal> comparing nul-terminated
> strings, so length is not required (it's just a simple wrapper around
> the functions you've already implemented).
Sent the current version of the patch [1].
1.
https://lists.tarantool.org/tarantool-patches/a860626525b4c5c6c82f1983d8ed9ffdb20a5a30.1698775628.git.sergeyb@tarantool.org/
>
> Anyway, I'd like to ask you to send the aforementioned patch.
>
next prev parent reply other threads:[~2023-10-31 18:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 14:15 Sergey Bronnikov via Tarantool-patches
2023-10-08 14:58 ` Maxim Kokryashkin via Tarantool-patches
2023-10-09 14:11 ` Sergey Kaplun via Tarantool-patches
2023-10-10 12:33 ` Sergey Bronnikov via Tarantool-patches
2023-10-31 16:00 ` Igor Munkin via Tarantool-patches
2023-10-31 18:14 ` Sergey Bronnikov via Tarantool-patches [this message]
2023-10-31 19:22 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4833d8b4-7b0d-4955-94d7-c8a2b53b9996@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=imun@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=sergeyb@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit][v2] LJ_GC64: Fix lua_concat().' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox